Skip to content

Commit b6dcb74

Browse files
committed
some fixes
- tracesSampleRate: 1 - environment: 'qa' - add to CI
1 parent 859ec81 commit b6dcb74

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -859,6 +859,7 @@ jobs:
859859
'create-remix-app-express',
860860
'create-remix-app-express-legacy',
861861
'create-remix-app-express-vite-dev',
862+
'default-browser',
862863
'node-express-esm-loader',
863864
'node-express-esm-preload',
864865
'node-express-esm-without-loader',

dev-packages/e2e-tests/test-applications/default-browser/src/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
import * as Sentry from '@sentry/react';
1+
import * as Sentry from '@sentry/browser';
22

33
Sentry.init({
4-
release: 'e2e-test',
54
dsn: process.env.E2E_TEST_DSN,
6-
tunnel: 'http://localhost:3031',
75
integrations: [Sentry.browserTracingIntegration()],
6+
tracesSampleRate: 1.0,
7+
release: 'e2e-test',
8+
environment: 'qa',
9+
tunnel: 'http://localhost:3031',
810
});
911

1012
document.getElementById('exception-button').addEventListener('click', () => {

dev-packages/e2e-tests/test-applications/default-browser/tests/errors.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForError } from '@sentry-internal/test-utils';
33

4-
test('Should send correct error event', async ({ page }) => {
4+
test('captures an error', async ({ page }) => {
55
const errorEventPromise = waitForError('default-browser', event => {
66
return !event.type && event.exception?.values?.[0]?.value === 'I am an error!';
77
});

0 commit comments

Comments
 (0)