errorHandler should only annotate error, we want it to re-throw so do not return true

billyvg · mydea · commit b7444943ba6c · 2023-10-13T10:12:49.000+02:00
diff --git a/packages/browser-integration-tests/suites/replay/exceptions/template.html b/packages/browser-integration-tests/suites/replay/exceptions/template.html
@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <body>
+  </body>
+</html>
diff --git a/packages/browser-integration-tests/suites/replay/exceptions/test.ts b/packages/browser-integration-tests/suites/replay/exceptions/test.ts
@@ -0,0 +1,43 @@
+import { expect } from '@playwright/test';
+import { SDK_VERSION } from '@sentry/browser';
+
+import { sentryTest } from '../../../utils/fixtures';
+import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../../../utils/replayHelpers';
+
+sentryTest('exceptions within rrweb and re-thrown and annotated', async ({ getLocalTestPath, page, browserName}) => {
+  if (shouldSkipReplayTest() || browserName !== 'chromium') {
+    sentryTest.skip();
+  }
+
+  // const reqPromise0 = waitForReplayRequest(page, 0);
+  // const reqPromise1 = waitForReplayRequest(page, 1);
+  //
+  // await page.route('https://dsn.ingest.sentry.io/**/*', route => {
+  //   return route.fulfill({
+  //     status: 200,
+  //     contentType: 'application/json',
+  //     body: JSON.stringify({ id: 'test-id' }),
+  //   });
+  // });
+  //
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  await page.goto(url);
+
+expect(await page.evaluate(() => {
+  try {
+    const s = new CSSStyleSheet();
+    s.insertRule('body::-ms-expand{display: none}');
+    s.insertRule('body {background-color: #fff;}');
+    return s.cssRules.length;
+  } catch {
+    return false;
+  }
+  })).toBe(false);
+
+expect(await page.evaluate(() => {
+    const s = new CSSStyleSheet();
+    s.insertRule('body {background-color: #fff;}');
+    return s.cssRules.length;
+  })).toBe(1);
+})
diff --git a/packages/replay/src/integration.ts b/packages/replay/src/integration.ts
@@ -145,19 +145,8 @@ export class Replay implements Integration {
       // collect fonts, but be aware that `sentry.io` needs to be an allowed
       // origin for playback
       collectFonts: true,
-      errorHandler: (err: Error & {__rrweb__?: boolean, __source__?: string}) => {
-        try {
-          err.__rrweb__ = true;
-
-          // Re-throw as styled-components relies on thrown exception when CSS rule fails to be inserted.
-          if (err.__source__ === 'CSSStyleSheet.insertRule') {
-            throw err;
-          }
-        } catch {
-          // avoid any potential hazards here
-        }
-        // return true to suppress throwing the error inside of rrweb
-        return true;
+      errorHandler: (err: Error & {__rrweb__?: boolean}) => {
+        err.__rrweb__ = true;
       },
     };
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,8 @@ @@
 +<!DOCTYPE html>
 +<html>
 +  <head>
 +    <meta charset="utf-8" />
 +  </head>
 +  <body>
 +  </body>
 +</html>