build: Switch @sentry/angular to using eslint

Author: AbhiPrasad

.eslintignore

@@ -1,7 +1,6 @@
 # THIS IS A TEMPORARY FILE
 # THIS WILL BE REMOVED AFTER WE FINISH ESLINT UPGRADE
 
-packages/angular/**/*
 packages/ember/**/*
 packages/gatsby/**/*
 packages/integrations/**/*

packages/angular/.eslintrc.js

@@ -0,0 +1,19 @@
+module.exports = {
+  root: true,
+  env: {
+    es6: true,
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+  },
+  extends: ['../../.eslintrc.js'],
+  ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx', '*.d.ts'],
+      parserOptions: {
+        project: './tsconfig.json',
+      },
+    },
+  ],
+};

packages/angular/package.json

@@ -42,13 +42,12 @@
     "build:watch:esm": "tsc -p tsconfig.esm.json -w --preserveWatchOutput",
     "clean": "rimraf dist coverage build esm",
     "link:yarn": "yarn link",
-    "lint": "run-s lint:prettier lint:tslint",
-    "lint:prettier": "prettier-check \"{src,test}/**/*.{ts,tsx}\"",
-    "lint:tslint": "tslint -t stylish -p .",
-    "lint:tslint:json": "tslint --format json -p . | tee lint-results.json",
-    "fix": "run-s fix:tslint fix:prettier",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.{ts,tsx}\"",
-    "fix:tslint": "tslint --fix -t stylish -p ."
+    "lint": "run-s lint:prettier lint:eslint",
+    "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
+    "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
+    "fix": "run-s fix:eslint fix:prettier",
+    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:eslint": "eslint . --format stylish --fix"
   },
   "sideEffects": false
 }

packages/angular/src/errorhandler.ts

@@ -61,6 +61,7 @@ class SentryErrorHandler implements AngularErrorHandler {
 
     // When in development mode, log the error to console for immediate feedback.
     if (this._options.logErrors) {
+      // eslint-disable-next-line no-console
       console.error(extractedError);
     }
 

packages/angular/src/tracing.ts

@@ -54,14 +54,7 @@ export function getActiveTransaction(): Transaction | undefined {
  */
 @Injectable({ providedIn: 'root' })
 export class TraceService {
-  private routingSpan?: Span;
-
-  public constructor(private readonly router: Router) {
-    this.navStart$.subscribe();
-    this.navEnd$.subscribe();
-  }
-
-  public navStart$: Observable<Event> = this.router.events.pipe(
+  public navStart$: Observable<Event> = this._router.events.pipe(
     filter(event => event instanceof NavigationStart),
     tap(event => {
       if (!instrumentationInitialized) {
@@ -80,7 +73,7 @@ export class TraceService {
       }
 
       if (activeTransaction) {
-        this.routingSpan = activeTransaction.startChild({
+        this._routingSpan = activeTransaction.startChild({
           description: `${navigationEvent.url}`,
           op: `angular.routing`,
           tags: {
@@ -95,15 +88,22 @@ export class TraceService {
     }),
   );
 
-  public navEnd$: Observable<Event> = this.router.events.pipe(
+  public navEnd$: Observable<Event> = this._router.events.pipe(
     filter(event => event instanceof NavigationEnd),
     tap(() => {
-      if (this.routingSpan) {
-        this.routingSpan.finish();
-        delete this.routingSpan;
+      if (this._routingSpan) {
+        this._routingSpan.finish();
+        delete this._routingSpan;
       }
     }),
   );
+
+  private _routingSpan?: Span;
+
+  public constructor(private readonly _router: Router) {
+    this.navStart$.subscribe();
+    this.navEnd$.subscribe();
+  }
 }
 
 const UNKNOWN_COMPONENT = 'unknown';
@@ -113,18 +113,18 @@ const UNKNOWN_COMPONENT = 'unknown';
  */
 @Directive({ selector: '[trace]' })
 export class TraceDirective implements OnInit, AfterViewInit {
-  private tracingSpan?: Span;
-
   @Input('trace') public componentName: string = UNKNOWN_COMPONENT;
 
+  private _tracingSpan?: Span;
+
   /**
    * Implementation of OnInit lifecycle method
    * @inheritdoc
    */
   public ngOnInit(): void {
     const activeTransaction = getActiveTransaction();
     if (activeTransaction) {
-      this.tracingSpan = activeTransaction.startChild({
+      this._tracingSpan = activeTransaction.startChild({
         description: `<${this.componentName}>`,
         op: `angular.initialize`,
       });
@@ -136,8 +136,8 @@ export class TraceDirective implements OnInit, AfterViewInit {
    * @inheritdoc
    */
   public ngAfterViewInit(): void {
-    if (this.tracingSpan) {
-      this.tracingSpan.finish();
+    if (this._tracingSpan) {
+      this._tracingSpan.finish();
     }
   }
 }
@@ -148,10 +148,11 @@ export class TraceDirective implements OnInit, AfterViewInit {
 export function TraceClassDecorator(): ClassDecorator {
   let tracingSpan: Span;
 
-  return (target: Function) => {
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+  return target => {
     // tslint:disable-next-line:no-unsafe-any
     const originalOnInit = target.prototype.ngOnInit;
-    // tslint:disable-next-line:no-unsafe-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     target.prototype.ngOnInit = function(...args: any[]): ReturnType<typeof originalOnInit> {
       const activeTransaction = getActiveTransaction();
       if (activeTransaction) {
@@ -161,14 +162,12 @@ export function TraceClassDecorator(): ClassDecorator {
         });
       }
       if (originalOnInit) {
-        // tslint:disable-next-line:no-unsafe-any
         return originalOnInit.apply(this, args);
       }
     };
 
-    // tslint:disable-next-line:no-unsafe-any
     const originalAfterViewInit = target.prototype.ngAfterViewInit;
-    // tslint:disable-next-line:no-unsafe-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     target.prototype.ngAfterViewInit = function(...args: any[]): ReturnType<typeof originalAfterViewInit> {
       if (tracingSpan) {
         tracingSpan.finish();
@@ -185,8 +184,10 @@ export function TraceClassDecorator(): ClassDecorator {
  * Decorator function that can be used to capture a single lifecycle methods of the component.
  */
 export function TraceMethodDecorator(): MethodDecorator {
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/ban-types
   return (target: Object, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
     const originalMethod = descriptor.value;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     descriptor.value = function(...args: any[]): ReturnType<typeof originalMethod> {
       const now = timestampWithMs();
       const activeTransaction = getActiveTransaction();