fix sampled flag

Author: Lms24

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/negatively-sampled/test.ts

@@ -34,6 +34,10 @@ sentryTest('includes a span link to a previously negatively sampled span', async
       },
     ]);
 
+    expect(navigationTraceContext?.data).toMatchObject({
+      'sentry.previous_trace': expect.stringMatching(/[a-f0-9]{32}-[a-f0-9]{16}-0/),
+    });
+
     expect(navigationTraceContext?.trace_id).not.toEqual(navigationTraceContext?.links![0].trace_id);
   });
 });

packages/browser/src/tracing/previousTrace.ts

@@ -1,11 +1,5 @@
 import type { Span } from '@sentry/core';
-import {
-  logger,
-  SEMANTIC_LINK_ATTRIBUTE_LINK_TYPE,
-  spanIsSampled,
-  spanToJSON,
-  type SpanContextData,
-} from '@sentry/core';
+import { logger, SEMANTIC_LINK_ATTRIBUTE_LINK_TYPE, spanToJSON, type SpanContextData } from '@sentry/core';
 import { WINDOW } from '../exports';
 import { DEBUG_BUILD } from '../debug-build';
 
@@ -49,7 +43,8 @@ export function addPreviousTraceSpanLink(
     };
   }
 
-  if (previousTraceInfo.spanContext.traceId === spanJson.trace_id) {
+  const previousTraceSpanCtx = previousTraceInfo.spanContext;
+  if (previousTraceSpanCtx.traceId === spanJson.trace_id) {
     // This means, we're still in the same trace so let's not update the previous trace info
     // or add a link to the current span.
     // Once we move away from the long-lived, route-based trace model, we can remove this cases
@@ -64,15 +59,15 @@ export function addPreviousTraceSpanLink(
   if (Date.now() / 1000 - previousTraceInfo.startTimestamp <= PREVIOUS_TRACE_MAX_DURATION) {
     if (DEBUG_BUILD) {
       logger.info(
-        `Adding previous_trace ${previousTraceInfo.spanContext} link to span ${{
+        `Adding previous_trace ${previousTraceSpanCtx} link to span ${{
           op: spanJson.op,
           ...span.spanContext(),
         }}`,
       );
     }
 
     span.addLink({
-      context: previousTraceInfo.spanContext,
+      context: previousTraceSpanCtx,
       attributes: {
         [SEMANTIC_LINK_ATTRIBUTE_LINK_TYPE]: 'previous_trace',
       },
@@ -84,7 +79,9 @@ export function addPreviousTraceSpanLink(
     // to check this at v10 time :)
     span.setAttribute(
       PREVIOUS_TRACE_TMP_SPAN_ATTRIBUTE,
-      `${previousTraceInfo.spanContext.traceId}-${previousTraceInfo.spanContext.spanId}-${spanIsSampled(span) ? 1 : 0}`,
+      `${previousTraceSpanCtx.traceId}-${previousTraceSpanCtx.spanId}-${
+        previousTraceSpanCtx.traceFlags === 0x1 ? 1 : 0
+      }`,
     );
   }