Skip to content

Commit bf75b3e

Browse files
committed
test remix sourcemaps optionally only
1 parent 112d9bd commit bf75b3e

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

.github/workflows/build.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,6 +1154,13 @@ jobs:
11541154
- false
11551155
label:
11561156
- false
1157+
include:
1158+
- test-application: 'create-remix-app'
1159+
build-command: 'test:build-sourcemaps'
1160+
label: 'create-remix-app (sourcemaps)'
1161+
- test-application: 'create-remix-app-legacy'
1162+
build-command: 'test:build-sourcemaps'
1163+
label: 'create-remix-app-legacy (sourcemaps)'
11571164

11581165
steps:
11591166
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})

dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22
"private": true,
33
"sideEffects": false,
44
"scripts": {
5-
"build": "remix build --sourcemap && ./upload-sourcemaps.sh",
5+
"build": "remix build --sourcemap",
6+
"upload-sourcemaps": "./upload-sourcemaps.sh",
67
"dev": "remix dev",
78
"start": "remix-serve build",
89
"typecheck": "tsc",
910
"clean": "npx rimraf node_modules pnpm-lock.yaml",
1011
"test:build": "pnpm install && npx playwright install && pnpm build",
12+
"test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
1113
"test:assert": "pnpm playwright test"
1214
},
1315
"dependencies": {

dev-packages/e2e-tests/test-applications/create-remix-app/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22
"private": true,
33
"sideEffects": false,
44
"scripts": {
5-
"build": "remix build --sourcemap && ./upload-sourcemaps.sh",
5+
"build": "remix build --sourcemap",
6+
"upload-sourcemaps": "./upload-sourcemaps.sh",
67
"dev": "remix dev",
78
"start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
89
"typecheck": "tsc",
910
"clean": "npx rimraf node_modules pnpm-lock.yaml",
1011
"test:build": "pnpm install && npx playwright install && pnpm build",
12+
"test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
1113
"test:assert": "pnpm playwright test"
1214
},
1315
"dependencies": {

0 commit comments

Comments
 (0)