Skip to content

Commit c3a6590

Browse files
authored
test(ember): Test that prod builds & source maps work (#9466)
broccoli-terser-sourcemap fixed a bug in [v4.1.1](https://github.com/ember-cli/broccoli-terser-sourcemap/releases/tag/v4.1.1) that affected building our SDK. This adds a test to ensure this continues to work. Closes #9168
1 parent 86c8d2a commit c3a6590

File tree

3 files changed

+32
-30
lines changed

3 files changed

+32
-30
lines changed

packages/ember/ember-cli-build.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,17 @@
33
const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
44

55
module.exports = function (defaults) {
6+
const environment = process.env.EMBER_ENV || 'development';
7+
const isProd = environment === 'production';
8+
69
const app = new EmberAddon(defaults, {
710
// Add options here
11+
sourcemaps: {
12+
enabled: isProd,
13+
},
14+
'ember-cli-terser': {
15+
enabled: isProd,
16+
},
817
});
918

1019
/*

packages/ember/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"fix:eslint": "eslint . --format stylish --fix",
2828
"fix:prettier": "prettier --write \"{addon,app,tests,config}/**/**.{ts,js}\"",
2929
"start": "ember serve",
30-
"test": "ember test",
30+
"test": "ember b --prod && ember test",
3131
"test:all": "ember try:each",
3232
"prepack": "ember ts:precompile",
3333
"postpack": "ember ts:clean"
@@ -61,7 +61,7 @@
6161
"ember-cli-inject-live-reload": "~2.1.0",
6262
"ember-cli-sri": "~2.1.1",
6363
"ember-cli-typescript-blueprints": "~3.0.0",
64-
"ember-cli-uglify": "~3.0.0",
64+
"ember-cli-terser": "~4.0.2",
6565
"ember-disable-prototype-extensions": "~1.1.3",
6666
"ember-load-initializers": "~2.1.1",
6767
"ember-maybe-import-regenerator": "~1.0.0",

yarn.lock

Lines changed: 21 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -9833,22 +9833,21 @@ broccoli-stew@^3.0.0:
98339833
symlink-or-copy "^1.2.0"
98349834
walk-sync "^1.1.3"
98359835

9836-
broccoli-uglify-sourcemap@^3.1.0:
9837-
version "3.2.0"
9838-
resolved "https://registry.yarnpkg.com/broccoli-uglify-sourcemap/-/broccoli-uglify-sourcemap-3.2.0.tgz#d96f1d41f6c18e9a5d49af1a5ab9489cdcac1c6c"
9839-
integrity sha512-kkkn8v7kXdWwnZNekq+3ILuTAGkZoaoEMUYCKoER5/uokuoyTjtdYLHaE7UxHkuPEuLfjvJYv21sCCePZ74/2g==
9836+
broccoli-terser-sourcemap@^4.1.0:
9837+
version "4.1.1"
9838+
resolved "https://registry.yarnpkg.com/broccoli-terser-sourcemap/-/broccoli-terser-sourcemap-4.1.1.tgz#4c26696e07a822e1fc91fb48c5b6d6c70d5ca9b2"
9839+
integrity sha512-8sbpRf0/+XeszBJQM7vph2UNj4Kal0lCI/yubcrBIzb2NvYj5gjTHJABXOdxx5mKNmlCMu2hx2kvOtMpQsxrfg==
98409840
dependencies:
98419841
async-promise-queue "^1.0.5"
9842-
broccoli-plugin "^1.2.1"
9843-
debug "^4.1.0"
9842+
broccoli-plugin "^4.0.7"
9843+
convert-source-map "^2.0.0"
9844+
debug "^4.3.1"
98449845
lodash.defaultsdeep "^4.6.1"
9845-
matcher-collection "^2.0.0"
9846-
mkdirp "^0.5.0"
9847-
source-map-url "^0.4.0"
9848-
symlink-or-copy "^1.0.1"
9849-
terser "^4.3.9"
9850-
walk-sync "^1.1.3"
9851-
workerpool "^5.0.1"
9846+
matcher-collection "^2.0.1"
9847+
symlink-or-copy "^1.3.1"
9848+
terser "^5.7.0"
9849+
walk-sync "^2.2.0"
9850+
workerpool "^6.1.5"
98529851

98539852
broccoli@^3.5.2:
98549853
version "3.5.2"
@@ -13149,6 +13148,13 @@ ember-cli-string-utils@^1.0.0, ember-cli-string-utils@^1.1.0:
1314913148
resolved "https://registry.yarnpkg.com/ember-cli-string-utils/-/ember-cli-string-utils-1.1.0.tgz#39b677fc2805f55173735376fcef278eaa4452a1"
1315013149
integrity sha1-ObZ3/CgF9VFzc1N2/O8njqpEUqE=
1315113150

13151+
ember-cli-terser@~4.0.2:
13152+
version "4.0.2"
13153+
resolved "https://registry.yarnpkg.com/ember-cli-terser/-/ember-cli-terser-4.0.2.tgz#c436a9e4159f76a615b051cba0584844652b7dcd"
13154+
integrity sha512-Ej77K+YhCZImotoi/CU2cfsoZaswoPlGaM5TB3LvjvPDlVPRhxUHO2RsaUVC5lsGeRLRiHCOxVtoJ6GyqexzFA==
13155+
dependencies:
13156+
broccoli-terser-sourcemap "^4.1.0"
13157+
1315213158
ember-cli-test-info@^1.0.0:
1315313159
version "1.0.0"
1315413160
resolved "https://registry.yarnpkg.com/ember-cli-test-info/-/ember-cli-test-info-1.0.0.tgz#ed4e960f249e97523cf891e4aed2072ce84577b4"
@@ -13259,14 +13265,6 @@ ember-cli-typescript@^5.2.1:
1325913265
stagehand "^1.0.0"
1326013266
walk-sync "^2.2.0"
1326113267

13262-
ember-cli-uglify@~3.0.0:
13263-
version "3.0.0"
13264-
resolved "https://registry.yarnpkg.com/ember-cli-uglify/-/ember-cli-uglify-3.0.0.tgz#8819665b2cc5fe70e3ba9fe7a94645209bc42fd6"
13265-
integrity sha512-n3QxdBfAgBdb2Cnso82Kt/nxm3ppIjnYWM8uhOEhF1aYxNXfM7AJrc+yiqTCDUR61Db8aCpHfAMvChz3kyme7g==
13266-
dependencies:
13267-
broccoli-uglify-sourcemap "^3.1.0"
13268-
lodash.defaultsdeep "^4.6.0"
13269-
1327013268
ember-cli-valid-component-name@^1.0.0:
1327113269
version "1.0.0"
1327213270
resolved "https://registry.yarnpkg.com/ember-cli-valid-component-name/-/ember-cli-valid-component-name-1.0.0.tgz#71550ce387e0233065f30b30b1510aa2dfbe87ef"
@@ -19956,7 +19954,7 @@ lodash.debounce@^4.0.8:
1995619954
resolved "https://registry.yarnpkg.com/lodash.debounce/-/lodash.debounce-4.0.8.tgz#82d79bff30a67c4005ffd5e2515300ad9ca4d7af"
1995719955
integrity sha1-gteb/zCmfEAF/9XiUVMArZyk168=
1995819956

19959-
lodash.defaultsdeep@^4.6.0, lodash.defaultsdeep@^4.6.1:
19957+
lodash.defaultsdeep@^4.6.1:
1996019958
version "4.6.1"
1996119959
resolved "https://registry.yarnpkg.com/lodash.defaultsdeep/-/lodash.defaultsdeep-4.6.1.tgz#512e9bd721d272d94e3d3a63653fa17516741ca6"
1996219960
integrity sha512-3j8wdDzYuWO3lM3Reg03MuQR957t287Rpcxp1njpEa8oDrikb+FwGdW3n+FELh/A6qib6yPit0j/pv9G/yeAqA==
@@ -29173,7 +29171,7 @@ [email protected]:
2917329171
source-map "~0.6.1"
2917429172
source-map-support "~0.5.12"
2917529173

29176-
terser@^4.1.2, terser@^4.3.9:
29174+
terser@^4.1.2:
2917729175
version "4.8.1"
2917829176
resolved "https://registry.yarnpkg.com/terser/-/terser-4.8.1.tgz#a00e5634562de2239fd404c649051bf6fc21144f"
2917929177
integrity sha512-4GnLC0x667eJG0ewJTa6z/yXrbLGv80D9Ru6HIpCQmO+Q4PfEtBFi0ObSckqwL6VyQv/7ENJieXHo2ANmdQwgw==
@@ -31498,11 +31496,6 @@ workerpool@^3.1.1:
3149831496
object-assign "4.1.1"
3149931497
rsvp "^4.8.4"
3150031498

31501-
workerpool@^5.0.1:
31502-
version "5.0.4"
31503-
resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-5.0.4.tgz#4f67cb70ff7550a27ab94de25b0b843cd92059a2"
31504-
integrity sha512-Sywova24Ow2NQ24JPB68bI89EdqMDjUXo4OpofK/QMD7C2ZVMloYBgQ5J3PChcBJHj2vspsmGx1/3nBKXtUkXQ==
31505-
3150631499
workerpool@^6.1.5, workerpool@^6.2.1:
3150731500
version "6.2.1"
3150831501
resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-6.2.1.tgz#46fc150c17d826b86a008e5a4508656777e9c343"

0 commit comments

Comments
 (0)