Skip to content

Commit c5c12a9

Browse files
authored
test(e2e): use 127.0.0.1 instead of localhost for E2E .npmrc (#9330)
Locally E2E tests keep hanging due to this, for whatever reason. Probably some DSN issues, but no idea why... Changing this to `127.0.0.1` fixes the problem :O
1 parent 42a60b6 commit c5c12a9

File tree

16 files changed

+34
-34
lines changed

16 files changed

+34
-34
lines changed

packages/e2e-tests/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ mkdir test-applications/my-new-test-application # Name of the new folder doesn't
4949

5050
# Create an npm configuration file that uses the fake test registry
5151
cat > test-applications/my-new-test-application/.npmrc << EOF
52-
@sentry:registry=http://localhost:4873
53-
@sentry-internal:registry=http://localhost:4873
52+
@sentry:registry=http://127.0.0.1:4873
53+
@sentry-internal:registry=http://127.0.0.1:4873
5454
EOF
5555
```
5656

@@ -60,7 +60,7 @@ Add the new test app to `test-application` matrix in `.github/workflows/build.ym
6060
want to run a canary test, add it to the `canary.yml` workflow.
6161

6262
**An important thing to note:** In the context of the build/test commands the fake test registry is available at
63-
`http://localhost:4873`. It hosts all of our packages as if they were to be published with the state of the current
63+
`http://127.0.0.1:4873`. It hosts all of our packages as if they were to be published with the state of the current
6464
branch. This means we can install the packages from this registry via the `.npmrc` configuration as seen above. If you
6565
add Sentry dependencies to your test application, you should set the dependency versions set to `latest || *` in order
6666
for it to work with both regular and prerelease versions:
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
@sentry:registry=http://localhost:4873
2-
@sentry-internal:registry=http://localhost:4873
3-
//localhost:4873/:_authToken=some-token
1+
@sentry:registry=http://127.0.0.1:4873
2+
@sentry-internal:registry=http://127.0.0.1:4873
3+
//127.0.0.1:4873/:_authToken=some-token
44

55
# Do not notify about npm updates
66
update-notifier=false

0 commit comments

Comments
 (0)