add log & tests

Author: mydea

packages/browser-integration-tests/suites/public-api/instrumentation/setTimeout/subject.js

@@ -0,0 +1,5 @@
+function callback() {
+  throw new Error('setTimeout_error');
+}
+
+setTimeout(callback, 0);

packages/browser-integration-tests/suites/public-api/instrumentation/setTimeout/test.ts

@@ -0,0 +1,24 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';
+
+sentryTest('Instrumentation should capture errors in setTimeout', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+  expect(eventData.exception?.values).toHaveLength(1);
+  expect(eventData.exception?.values?.[0]).toMatchObject({
+    type: 'Error',
+    value: 'setTimeout_error',
+    mechanism: {
+      type: 'instrument',
+      handled: false,
+    },
+    stacktrace: {
+      frames: expect.any(Array),
+    },
+  });
+});

packages/browser-integration-tests/suites/public-api/instrumentation/setTimeoutFrozen/init.js

@@ -0,0 +1,8 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  debug: true,
+});

packages/browser-integration-tests/suites/public-api/instrumentation/setTimeoutFrozen/subject.js

@@ -0,0 +1,5 @@
+function callback() {
+  throw new Error('setTimeout_error');
+}
+
+setTimeout(Object.freeze(callback), 0);

packages/browser-integration-tests/suites/public-api/instrumentation/setTimeoutFrozen/test.ts

@@ -0,0 +1,42 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';
+
+sentryTest(
+  'Instrumentation does not fail when using frozen callback for setTimeout',
+  async ({ getLocalTestPath, page }) => {
+    const url = await getLocalTestPath({ testDir: __dirname });
+
+    const logMessages: string[] = [];
+
+    page.on('console', msg => {
+      logMessages.push(msg.text());
+    });
+
+    const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+    // It still captures the error
+    expect(eventData.exception?.values).toHaveLength(1);
+    expect(eventData.exception?.values?.[0]).toMatchObject({
+      type: 'Error',
+      value: 'setTimeout_error',
+      mechanism: {
+        type: 'instrument',
+        handled: false,
+      },
+      stacktrace: {
+        frames: expect.any(Array),
+      },
+    });
+
+    expect(logMessages).toEqual(
+      expect.arrayContaining([
+        expect.stringContaining(
+          'Sentry Logger [log]: Failed to add non-enumerable property "__sentry_wrapped__" to object function callback()',
+        ),
+      ]),
+    );
+  },
+);

packages/utils/src/object.ts

@@ -4,6 +4,7 @@ import type { WrappedFunction } from '@sentry/types';
 
 import { htmlTreeAsString } from './browser';
 import { isElement, isError, isEvent, isInstanceOf, isPlainObject, isPrimitive } from './is';
+import { logger } from './logger';
 import { truncate } from './string';
 
 /**
@@ -49,7 +50,9 @@ export function addNonEnumerableProperty(obj: { [key: string]: unknown }, name:
       writable: true,
       configurable: true,
     });
-  } catch (o_O) {} // eslint-disable-line no-empty
+  } catch (o_O) {
+    __DEBUG_BUILD__ && logger.log(`Failed to add non-enumerable property "${name}" to object`, obj);
+  }
 }
 
 /**