Merge branch 'develop' into fn/e2e-tests

Author: Luca Forstner

.craft.yml

@@ -11,6 +11,8 @@ targets:
           - nodejs10.x
           - nodejs12.x
           - nodejs14.x
+          - nodejs16.x
+          - nodejs18.x
     license: MIT
   - name: gcs
     includeNames: /.*\.js.*$/
@@ -22,7 +24,6 @@ targets:
   - name: github
     includeNames: /^sentry-.*$/
   - name: npm
-    excludeNames: /^sentry-sveltekit-.*$/
   - name: registry
     sdks:
       'npm:@sentry/browser':

.github/codeql/codeql-config.yml

@@ -0,0 +1,4 @@
+paths-ignore:
+  # Our tsconfig files contain comments, which CodeQL complains about
+  - '**/tsconfig.json'
+  - '**/tsconfig.*.json'

.github/workflows/build.yml

@@ -321,8 +321,10 @@ jobs:
         uses: ./.github/actions/restore-cache
         env:
           DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
-      - name: Run linter
+      - name: Lint source files
         run: yarn lint
+      - name: Validate ES5 builds
+        run: yarn validate:es5
 
   job_circular_dep_check:
     name: Circular Dependency Check
@@ -369,7 +371,6 @@ jobs:
           path: |
             ${{ github.workspace }}/packages/browser/build/bundles/**
             ${{ github.workspace }}/packages/integrations/build/bundles/**
-            ${{ github.workspace }}/packages/tracing/build/bundles/**
             ${{ github.workspace }}/packages/replay/build/bundles/**
             ${{ github.workspace }}/packages/**/*.tgz
 
@@ -480,7 +481,7 @@ jobs:
           yarn test:integration
 
   job_browser_playwright_tests:
-    name: Playwright (${{ matrix.bundle }})${{ (matrix.tracing_only && ' tracing only') || '' }} Tests
+    name: Playwright (${{ matrix.bundle }}) Tests
     needs: [job_get_metadata, job_build]
     if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
     runs-on: ubuntu-20.04
@@ -497,16 +498,13 @@ jobs:
           - bundle_es6_min
           - bundle_replay_es6
           - bundle_replay_es6_min
-        tracing_only:
-          - true
-          - false
-        exclude:
-          # `tracing_only` only makes a difference for bundles - tests of the esm and cjs builds always include the
-          # tracing tests
-          - bundle: esm
-            tracing_only: false
-          - bundle: cjs
-            tracing_only: false
+          - bundle_tracing_es5
+          - bundle_tracing_es5_min
+          - bundle_tracing_es6
+          - bundle_tracing_es6_min
+          - bundle_tracing_replay_es6
+          - bundle_tracing_replay_es6_min
+
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v3
@@ -541,7 +539,6 @@ jobs:
       - name: Run Playwright tests
         env:
           PW_BUNDLE: ${{ matrix.bundle }}
-          PW_TRACING_ONLY: ${{ matrix.tracing_only }}
         run: |
           cd packages/browser-integration-tests
           yarn test:ci

.github/workflows/codeql-analysis.yml

@@ -50,6 +50,7 @@ jobs:
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v2
         with:
+          config-file: ./.github/codeql/codeql-config.yml
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
           # By default, queries listed here will override any specified in a config file.

.github/workflows/flaky-test-detector.yml

@@ -0,0 +1,81 @@
+name: 'Detect flaky tests'
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - 'packages/browser-integration-tests/suites/**'
+
+env:
+  HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }}
+
+  NX_CACHE_RESTORE_KEYS: |
+    nx-Linux-${{ github.ref }}-${{ github.event.inputs.commit || github.sha }}
+    nx-Linux-${{ github.ref }}
+    nx-Linux
+
+# Cancel in progress workflows on pull_requests.
+# https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  flaky-detector:
+    runs-on: ubuntu-20.04
+    timeout-minutes: 60
+    name: 'Check tests for flakiness'
+    steps:
+      - name: Check out current branch
+        uses: actions/checkout@v3
+      - name: Set up Node
+        uses: volta-cli/action@v4
+
+      - name: Install dependencies
+        run: yarn install --ignore-engines --frozen-lockfile
+
+      - name: NX cache
+        uses: actions/cache/restore@v3
+        with:
+          path: .nxcache
+          key: nx-Linux-${{ github.ref }}-${{ env.HEAD_COMMIT }}
+          restore-keys: ${{ env.NX_CACHE_RESTORE_KEYS }}
+
+      - name: Build packages
+        run: yarn build
+
+      - name: Get npm cache directory
+        id: npm-cache-dir
+        run: echo "dir=$(npm config get cache)" >> $GITHUB_OUTPUT
+      - name: Get Playwright version
+        id: playwright-version
+        run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
+      - uses: actions/cache@v3
+        name: Check if Playwright browser is cached
+        id: playwright-cache
+        with:
+          path: ${{ steps.npm-cache-dir.outputs.dir }}
+          key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
+      - name: Install Playwright browser if not cached
+        if: steps.playwright-cache.outputs.cache-hit != 'true'
+        run: npx playwright install --with-deps
+        env:
+          PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
+      - name: Install OS dependencies of Playwright if cache hit
+        if: steps.playwright-cache.outputs.cache-hit == 'true'
+        run: npx playwright install-deps
+
+      - name: Determine changed tests
+        uses: getsentry/[email protected]
+        id: changed
+        with:
+          list-files: json
+          filters: |
+            browser_integration: packages/browser-integration-tests/suites/**
+
+      - name: Detect flaky tests
+        run: yarn test:detect-flaky
+        working-directory: packages/browser-integration-tests
+        env:
+          CHANGED_TEST_PATHS: ${{ steps.changed.outputs.browser_integration_files }}
+          # Run 50 times when detecting changed test(s), else run all tests 5x
+          TEST_RUN_COUNT: ${{ steps.changed.outputs.browser_integration == 'true' && 50 || 5 }}

.github/workflows/release-size-info.yml

@@ -17,18 +17,9 @@ jobs:
     name: 'Add size-limit info to release'
 
     steps:
-      # https://github.com/actions-ecosystem/action-regex-match
-      - name: Extract version from ref
-        uses: actions-ecosystem/action-regex-match@v2
-        id: head_version
-        with:
-          # Parse version from head ref, which is refs/tags/<tag_name>
-          text: ${{ env.GITHUB_REF }}
-          regex: '^refs\/tags\/([\d.]+)$'
-
       - name: Get version
         id: get_version
-        run: echo "version=${{ github.event.inputs.version || steps.head_version.outputs.group1 }}" >> $GITHUB_OUTPUT
+        run: echo "version=${{ github.event.inputs.version || github.event.release.tag_name }}" >> $GITHUB_OUTPUT
 
       - name: Update Github Release
         if: steps.get_version.outputs.version != ''

.size-limit.js

@@ -53,13 +53,13 @@ module.exports = [
   },
   {
     name: '@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)',
-    path: 'packages/tracing/build/bundles/bundle.tracing.es5.min.js',
+    path: 'packages/browser/build/bundles/bundle.tracing.es5.min.js',
     gzip: true,
     limit: '37 KB',
   },
   {
     name: '@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)',
-    path: 'packages/tracing/build/bundles/bundle.tracing.min.js',
+    path: 'packages/browser/build/bundles/bundle.tracing.min.js',
     gzip: true,
     limit: '35 KB',
   },
@@ -80,7 +80,7 @@ module.exports = [
   },
   {
     name: '@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)',
-    path: 'packages/tracing/build/bundles/bundle.tracing.replay.min.js',
+    path: 'packages/browser/build/bundles/bundle.tracing.replay.min.js',
     gzip: true,
     limit: '80 KB',
   },

CHANGELOG.md

@@ -4,6 +4,70 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 7.45.0
+
+- build(cdn): Ensure ES5 bundles do not use non-ES5 code (#7550)
+- feat(core): Add trace function (#7556)
+- feat(hub): Make scope always defined on the hub (#7551)
+- feat(replay): Add `replay_id` to transaction DSC (#7571)
+- feat(replay): Capture fetch body size for replay events (#7524)
+- feat(sveltekit): Add performance monitoring for client load (#7537)
+- feat(sveltekit): Add performance monitoring for server load (#7536)
+- feat(sveltekit): Add performance monitoring to Sveltekit server handle (#7532)
+- feat(sveltekit): Add SvelteKit routing instrumentation (#7565)
+- fix(browser): Ensure keepalive flag is correctly set for parallel requests (#7553)
+- fix(core): Ensure `ignoreErrors` only applies to error events (#7573)
+- fix(node): Consider tracing error handler for process exit (#7558)
+- fix(otel): Make sure we use correct hub on finish (#7577)
+- fix(react): Handle case where error.cause already defined (#7557)
+
+## 7.44.2
+
+- fix(cdn): Fix ES5 CDN bundles (#7544)
+
+## 7.44.1
+
+- ref(core): Move beforeEnvelope to client (#7527)
+
+## 7.44.0
+
+This release introduces the first alpha version of `@sentry/sveltekit`, our newest JavaScript SDK for Sveltekit. Check out the [README](./packages/sveltekit/README.md) for usage instructions and what to expect from this alpha release.
+
+- feat(replay): Add `request_body_size` & `response_body_size` to fetch/xhr (#7407)
+- feat(replay): Add additional properties for UI clicks (#7395)
+- feat(replay): Reduce time limit before pausing a recording (#7356)
+- feat(replay): Upgrade `rrweb` and `rrweb-player` (#7508)
+- feat(replay): Use new afterSend hook to improve error linking (#7390)
+- feat(serverless): Publish lambda layer for Node 16/18 (#7483)
+- feat(sveltekit): Add wrapper for client load function (#7447)
+- feat(sveltekit): Add wrapper for server load function (#7416)
+- feat(sveltekit): Add server-side `handleError` wrapper (#7411)
+- feat(sveltekit): Introduce client-side `handleError` wrapper (#7406)
+- feat(sveltekit): Add SvelteKit client and server `init` functions (#7408)
+- feat(sveltekit): Inject `Sentry.init` calls into server and client bundles (#7391)
+- feat(tracing): Expose `BrowserTracing` in non-tracing bundles (#7479)
+- fix(core): Permanent idle timeout cancel finishes the transaction with the last finished child
+- fix(integrations): Handle lower-case prefix windows paths in `RewriteFrames` (#7506)
+- fix(next): Guard against missing serverSideProps (#7517)
+- fix(nextjs): Fix broken server component wrapping because of interrupted promise chain (#7456)
+- fix(nextjs): Fix runtime error for static pages (#7476)
+- fix(profiling): Catch sendProfile rejection (#7446)
+- fix(replay): Never capture file input changes (#7485)
+- fix(serverless): Explicitly export node package exports (#7457)
+- fix(vue): Do not depend on `window.location` for SSR environments (#7518)
+
+
+**Replay `rrweb` changes:**
+
+`@sentry-internal/rrweb` was updated from 1.105.0 to 1.106.0:
+
+- feat: Ensure password inputs are always masked ([#78](https://github.com/getsentry/rrweb/pull/78))
+- fix: Ensure text masking for updated attributes works ([#83](https://github.com/getsentry/rrweb/pull/83))
+- fix: Ensure unmaskTextSelector is used for masked attributes ([#81](https://github.com/getsentry/rrweb/pull/81))
+- fix: Mask <option> values for selects & radio/checkbox value ([#75](https://github.com/getsentry/rrweb/pull/75))
+
+Work in this release contributed by @woochanleee and @baked-dev. Thank you for your contribution!
+
 ## 7.43.0
 
 - feat(nextjs): Run source map upload in Vercel develop and preview environments (#7436)

CODEOWNERS

@@ -0,0 +1,3 @@
+packages/replay                                   @getsentry/replay-sdk
+packages/replay-worker                            @getsentry/replay-sdk
+packages/browser-integration-tests/suites/replay  @getsentry/replay-sdk

CONTRIBUTING.md

@@ -33,6 +33,15 @@ Since we are using [`TypeScript`](https://www.typescriptlang.org/), you need to
 - `yarn build:dev:filter <name of npm package>`, which runs `yarn build:dev` only in projects relevant to the given package (so, for example, running `yarn build:dev:filter @sentry/react` will build the `react` package, all of its dependencies (`utils`, `core`, `browser`, etc), and all packages which depend on it (currently `gatsby` and `nextjs`))
 - `yarn build:dev:watch`, which runs `yarn build:dev` in watch mode (recommended)
 
+
+## Testing SDK Packages Locally
+
+To test local versions of SDK packages, for instance in test projects, you have a couple of options:
+
+* Use [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/) to symlink your package to the test project.
+* Use [`yalc` to install SDK packages](./docs/using-yalc.md) as if they were already published.
+* Run `build:tarball` in the repo and `yarn add ./path/to/tarball.tgz` in the project.
+
 ## Adding Tests
 
 **Any nontrivial fixes/features should include tests.** You'll find a `test` folder in each package.

README.md

@@ -18,15 +18,6 @@ faster, so we can get back to enjoying technology. If you want to join us
 This is the next line of Sentry JavaScript SDKs, comprised in the `@sentry/` namespace. It will provide a more
 convenient interface and improved consistency between various JavaScript environments.
 
----
-
-**Sentry is Hiring!!!**
-
-Would you like to work on Open Source software and help maintain this repository? Apply today:
-https://boards.greenhouse.io/sentry.
-
----
-
 ## Links
 
 - [![Documentation](https://img.shields.io/badge/documentation-sentry.io-green.svg)](https://docs.sentry.io/quickstart/)

docs/new-sdk-release-checklist.md

@@ -44,6 +44,9 @@ This page serves as a checklist of what to do when releasing a new SDK for the f
     - **This is especially important, if you're adding new CDN bundles!**
     - Tarballs (*.tgz archives) should work OOTB
 
+
+- [ ] Make sure it is added to `bundlePlugins.ts:makeTSPlugin` as `paths`, otherwise it will not be ES5 transpiled correctly for CDN builds.
+
 ## Cutting the Release
 
 When you’re ready to make the first release, there are a couple of steps that need to be performed in the **correct order**. Note that you can prepare the PRs at any time but the **merging oder** is important:

docs/using-yalc.md

@@ -0,0 +1,51 @@
+# Using `yalc` for Local SDK Testing
+
+[Yalc](https://github.com/wclr/yalc) is a simple local dependency repository which we can use to work with local versions of our SDKs.
+This is a good alternative to `npm|yarn link` for packages where linking is problematic (e.g. SvelteKit or Angular).
+
+Here's how to set up and use yalc:
+
+## Installing `yalc`
+
+Either install yalc globally,
+
+```sh
+npm install -g yalc
+
+yarn global add yalc
+```
+
+or add it to your desired test projects (same command without the `-g|global` flags)
+
+## Registering/Updating packages
+
+Whenever you want to make your local changes available to your test projects (e.g. after a local code change), run:
+
+```sh
+yarn yalc:publish
+```
+
+If you run this command in the root of the repo, this will publish all SDK packages to the local yalc repo. If you run it in a specific SDK package, it will just publish this package. You **don't need to** call `yalc update` in your test project. Already linked test projects will be update automatically.
+
+## Using yalc packages
+
+In your test project, run
+
+```sh
+yalc add @sentry/browser #or any other SDK package
+```
+
+to add the local SDK package to your project.
+
+**Important:** You need to `yalc add` the dependencies of the SDK package as well (e.g. core, utils, types, etc.).
+
+## Troubleshooting:
+
+### My changes are not applied to the test project
+
+Did you run `yarn build && yarn publish:yalc` after making your changes?
+
+### My test project uses Vite and I still don't see changes
+
+Vite pre-bundles and caches dependencies for dev builds. It [doesn't recognize changes in yalc packages though](https://github.com/wclr/yalc/issues/189) :( To make these changes show up anyway, run `vite dev --force`.
+

lerna.json

@@ -1,6 +1,6 @@
 {
   "$schema": "node_modules/lerna/schemas/lerna-schema.json",
-  "version": "7.43.0",
+  "version": "7.45.0",
   "npmClient": "yarn",
   "useWorkspaces": true
 }