Send along the session duration as extra

Author: mattrobenolt

src/raven.js

@@ -25,7 +25,8 @@ var _Raven = window.Raven,
     authQueryString,
     isRavenInstalled = false,
 
-    objectPrototype = Object.prototype;
+    objectPrototype = Object.prototype,
+    startTime = now();
 
 /*
  * The core Raven singleton
@@ -623,6 +624,10 @@ function truncate(str, max) {
     return str.length <= max ? str : str.substr(0, max) + '\u2026';
 }
 
+function now() {
+    return +new Date();
+}
+
 function getHttpData() {
     var http = {
         url: document.location.href,
@@ -654,9 +659,13 @@ function send(data) {
     data.tags = objectMerge(globalOptions.tags, data.tags);
     data.extra = objectMerge(globalOptions.extra, data.extra);
 
+    // Send along our own collected metadata with extra
+    data.extra = objectMerge({
+        'session:duration': now() - startTime,
+    }, data.extra);
+
     // If there are no tags/extra, strip the key from the payload alltogther.
     if (isEmptyObject(data.tags)) delete data.tags;
-    if (isEmptyObject(data.extra)) delete data.extra;
 
     if (globalUser) {
         // sentry.interfaces.User

test/raven.test.js

@@ -16,7 +16,10 @@ function flushRavenState() {
         maxMessageLength: 100,
         tags: {},
         extra: {}
-    };
+    },
+    startTime = 0
+    ;
+
     Raven.uninstall();
 }
 
@@ -41,6 +44,11 @@ function uuid4() {
     return 'abc123';
 }
 
+// patched to be predictable
+function now() {
+    return 100;
+}
+
 describe('TraceKit', function(){
     describe('error notifications', function(){
         var testMessage = "__mocha_ignore__";
@@ -815,7 +823,8 @@ describe('globals', function() {
                     }
                 },
                 event_id: 'abc123',
-                foo: 'bar'
+                foo: 'bar',
+                extra: {'session:duration': 100}
             });
         });
 
@@ -851,7 +860,8 @@ describe('globals', function() {
                 user: {
                     name: 'Matt'
                 },
-                foo: 'bar'
+                foo: 'bar',
+                extra: {'session:duration': 100}
             }]);
         });
 
@@ -884,7 +894,8 @@ describe('globals', function() {
                     }
                 },
                 event_id: 'abc123',
-                tags: {tag1: 'value1', tag2: 'value2'}
+                tags: {tag1: 'value1', tag2: 'value2'},
+                extra: {'session:duration': 100}
             }]);
         });
 
@@ -917,7 +928,7 @@ describe('globals', function() {
                     }
                 },
                 event_id: 'abc123',
-                extra: {key1: 'value1', key2: 'value2'}
+                extra: {key1: 'value1', key2: 'value2', 'session:duration': 100}
             }]);
         });
 
@@ -943,7 +954,7 @@ describe('globals', function() {
             }]);
         });
 
-        it('should strip empty tags/extra', function() {
+        it('should strip empty tags', function() {
             this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'makeRequest');
             this.sinon.stub(window, 'getHttpData').returns({
@@ -955,8 +966,7 @@ describe('globals', function() {
                 projectId: 2,
                 logger: 'javascript',
                 site: 'THE BEST',
-                tags: {},
-                extra: {}
+                tags: {}
             };
 
             send({foo: 'bar', tags: {}, extra: {}});
@@ -972,7 +982,8 @@ describe('globals', function() {
                     }
                 },
                 event_id: 'abc123',
-                foo: 'bar'
+                foo: 'bar',
+                extra: {'session:duration': 100}
             });
         });
     });