Skip to content

Commit d136f4e

Browse files
ref(eslint): Consolidate initial set of packages (#4102)
Convert angular, core, gatsby, hub, integrations, minimal, tracing, types, utils, vue, wasm. Certain packages (browser, react, nextjs, serverless, node) skipped as they are more involved. Co-authored-by: iker barriocanal <[email protected]>
1 parent 115b0f3 commit d136f4e

30 files changed

+55
-261
lines changed

.eslintrc.js

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
module.exports = {
2+
root: true,
3+
env: {
4+
es6: true,
5+
},
6+
parserOptions: {
7+
ecmaVersion: 2018,
8+
},
9+
extends: ['@sentry-internal/sdk'],
10+
ignorePatterns: [
11+
'coverage/**',
12+
'build/**',
13+
'dist/**',
14+
'esm/**',
15+
'examples/**',
16+
'scripts/**',
17+
'test/manual/**',
18+
],
19+
overrides: [
20+
{
21+
files: ['*.ts', '*.tsx', '*.d.ts'],
22+
parserOptions: {
23+
project: './tsconfig.json',
24+
},
25+
}
26+
],
27+
};

packages/angular/.eslintrc.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,6 @@
11
module.exports = {
2-
root: true,
32
env: {
4-
es6: true,
53
browser: true,
64
},
7-
parserOptions: {
8-
ecmaVersion: 2018,
9-
},
10-
extends: ['@sentry-internal/sdk'],
11-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
12-
overrides: [
13-
{
14-
files: ['*.ts', '*.tsx', '*.d.ts'],
15-
parserOptions: {
16-
project: './tsconfig.json',
17-
},
18-
},
19-
],
5+
extends: ['../../.eslintrc.js'],
206
};

packages/angular/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
"@angular/common": "^10.0.3",
3232
"@angular/core": "^10.0.3",
3333
"@angular/router": "^10.0.3",
34-
"@sentry-internal/eslint-config-sdk": "6.13.3",
3534
"npm-run-all": "^4.1.2",
3635
"prettier": "1.19.0",
3736
"rimraf": "^2.6.3",

packages/core/.eslintrc.js

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,3 @@
11
module.exports = {
2-
root: true,
3-
env: {
4-
es6: true,
5-
},
6-
parserOptions: {
7-
ecmaVersion: 2018,
8-
},
9-
extends: ['@sentry-internal/sdk'],
10-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
11-
overrides: [
12-
{
13-
files: ['*.ts', '*.tsx', '*.d.ts'],
14-
parserOptions: {
15-
project: './tsconfig.json',
16-
},
17-
},
18-
{
19-
files: ['test/**'],
20-
rules: {
21-
'@typescript-eslint/no-explicit-any': 'off',
22-
'@typescript-eslint/no-non-null-assertion': 'off',
23-
},
24-
},
25-
],
2+
extends: ['../../.eslintrc.js'],
263
};

packages/core/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
"tslib": "^1.9.3"
2424
},
2525
"devDependencies": {
26-
"@sentry-internal/eslint-config-sdk": "6.13.3",
2726
"jest": "^24.7.1",
2827
"npm-run-all": "^4.1.2",
2928
"prettier": "1.19.0",

packages/eslint-config-sdk/src/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,15 +163,16 @@ module.exports = {
163163
env: {
164164
jest: true,
165165
},
166-
files: ['*.test.ts', '*.test.tsx', '*.test.js', '*.test.jsx'],
166+
files: ['*.test.ts', '*.test.tsx', '*.test.js', '*.test.jsx', 'test/**/*.ts', 'test/**/*.js'],
167167
rules: {
168168
'max-lines': 'off',
169-
170169
'@typescript-eslint/explicit-function-return-type': 'off',
171170
'no-unused-expressions': 'off',
172171
'@typescript-eslint/no-unused-expressions': 'off',
173172
'@typescript-eslint/no-unsafe-member-access': 'off',
174173
'@typescript-eslint/explicit-member-accessibility': 'off',
174+
'@typescript-eslint/no-explicit-any': 'off',
175+
'@typescript-eslint/no-non-null-assertion': 'off',
175176
},
176177
},
177178
{

packages/gatsby/.eslintrc.js

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,10 @@
11
module.exports = {
2-
root: true,
32
env: {
4-
es6: true,
53
browser: true,
64
node: true,
75
},
86
parserOptions: {
9-
ecmaVersion: 2018,
107
jsx: true,
118
},
12-
extends: ['@sentry-internal/sdk'],
13-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
14-
overrides: [
15-
{
16-
files: ['*.ts', '*.tsx', '*.d.ts'],
17-
parserOptions: {
18-
project: './tsconfig.json',
19-
},
20-
},
21-
],
9+
extends: ['../../.eslintrc.js'],
2210
};

packages/gatsby/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"gatsby": "^2.0.0 || ^3.0.0"
3434
},
3535
"devDependencies": {
36-
"@sentry-internal/eslint-config-sdk": "6.13.3",
3736
"@sentry/types": "6.13.3",
3837
"@testing-library/react": "^10.4.9",
3938
"jest": "^24.7.1",

packages/hub/.eslintrc.js

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,3 @@
11
module.exports = {
2-
root: true,
3-
env: {
4-
es6: true,
5-
},
6-
parserOptions: {
7-
ecmaVersion: 2018,
8-
},
9-
extends: ['@sentry-internal/sdk'],
10-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
11-
overrides: [
12-
{
13-
files: ['*.ts', '*.tsx', '*.d.ts'],
14-
parserOptions: {
15-
project: './tsconfig.json',
16-
},
17-
},
18-
{
19-
files: ['test/**'],
20-
rules: {
21-
'@typescript-eslint/no-explicit-any': 'off',
22-
'@typescript-eslint/no-non-null-assertion': 'off',
23-
},
24-
},
25-
],
2+
extends: ['../../.eslintrc.js'],
263
};

packages/hub/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"tslib": "^1.9.3"
2222
},
2323
"devDependencies": {
24-
"@sentry-internal/eslint-config-sdk": "6.13.3",
2524
"jest": "^24.7.1",
2625
"npm-run-all": "^4.1.2",
2726
"prettier": "1.19.0",

packages/integrations/.eslintrc.js

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,3 @@
11
module.exports = {
2-
root: true,
3-
env: {
4-
es6: true,
5-
},
6-
parserOptions: {
7-
ecmaVersion: 2018,
8-
},
9-
extends: ['@sentry-internal/sdk'],
10-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
11-
overrides: [
12-
{
13-
files: ['*.ts', '*.tsx', '*.d.ts'],
14-
parserOptions: {
15-
project: './tsconfig.json',
16-
},
17-
},
18-
{
19-
files: ['test/**'],
20-
env: {
21-
mocha: true,
22-
},
23-
rules: {
24-
'@typescript-eslint/no-explicit-any': 'off',
25-
'@typescript-eslint/no-non-null-assertion': 'off',
26-
},
27-
},
28-
],
2+
extends: ['../../.eslintrc.js'],
293
};

packages/integrations/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"tslib": "^1.9.3"
2323
},
2424
"devDependencies": {
25-
"@sentry-internal/eslint-config-sdk": "6.13.3",
2625
"chai": "^4.1.2",
2726
"jest": "^24.7.1",
2827
"npm-run-all": "^4.1.2",

packages/minimal/.eslintrc.js

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,3 @@
11
module.exports = {
2-
root: true,
3-
env: {
4-
es6: true,
5-
},
6-
parserOptions: {
7-
ecmaVersion: 2018,
8-
},
9-
extends: ['@sentry-internal/sdk'],
10-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
11-
overrides: [
12-
{
13-
files: ['*.ts', '*.tsx', '*.d.ts'],
14-
parserOptions: {
15-
project: './tsconfig.json',
16-
},
17-
},
18-
{
19-
files: ['test/**'],
20-
rules: {
21-
'@typescript-eslint/no-explicit-any': 'off',
22-
'@typescript-eslint/no-non-null-assertion': 'off',
23-
},
24-
},
25-
],
2+
extends: ['../../.eslintrc.js'],
263
};

packages/minimal/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"tslib": "^1.9.3"
2222
},
2323
"devDependencies": {
24-
"@sentry-internal/eslint-config-sdk": "6.13.3",
2524
"jest": "^24.7.1",
2625
"npm-run-all": "^4.1.2",
2726
"prettier": "1.19.0",

packages/node/.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module.exports = {
22
root: true,
33
env: {
4-
es6: true,
54
node: true,
65
},
76
parserOptions: {

packages/react/test/errorboundary.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { Scope } from '@sentry/browser';
2-
import { Event, Severity } from '@sentry/types';
32
import { fireEvent, render, screen } from '@testing-library/react';
43
import * as React from 'react';
54
import { useState } from 'react';

packages/tracing/.eslintrc.js

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,3 @@
11
module.exports = {
2-
root: true,
3-
env: {
4-
es6: true,
5-
},
6-
parserOptions: {
7-
ecmaVersion: 2018,
8-
},
9-
extends: ['@sentry-internal/sdk'],
10-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
11-
overrides: [
12-
{
13-
files: ['*.ts', '*.tsx', '*.d.ts'],
14-
parserOptions: {
15-
project: './tsconfig.json',
16-
},
17-
},
18-
{
19-
files: ['test/**'],
20-
rules: {
21-
'@typescript-eslint/no-explicit-any': 'off',
22-
'@typescript-eslint/no-non-null-assertion': 'off',
23-
},
24-
},
25-
],
2+
extends: ['../../.eslintrc.js'],
263
};

packages/tracing/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
"tslib": "^1.9.3"
2424
},
2525
"devDependencies": {
26-
"@sentry-internal/eslint-config-sdk": "6.13.3",
2726
"@sentry/browser": "6.13.3",
2827
"@types/express": "^4.17.1",
2928
"@types/jsdom": "^16.2.3",

packages/types/.eslintrc.js

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,6 @@
11
module.exports = {
2-
root: true,
3-
env: {
4-
es6: true,
5-
},
6-
parserOptions: {
7-
ecmaVersion: 2018,
8-
},
9-
extends: ['@sentry-internal/sdk'],
10-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
11-
overrides: [
12-
{
13-
files: ['*.ts', '*.tsx', '*.d.ts'],
14-
parserOptions: {
15-
project: './tsconfig.json',
16-
},
17-
},
18-
],
2+
extends: ['../../.eslintrc.js'],
193
rules: {
204
'@typescript-eslint/no-explicit-any': 'off',
21-
},
5+
}
226
};

packages/types/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
"access": "public"
1717
},
1818
"devDependencies": {
19-
"@sentry-internal/eslint-config-sdk": "6.13.3",
2019
"npm-run-all": "^4.1.2",
2120
"prettier": "1.19.0",
2221
"typescript": "3.7.5"

packages/utils/.eslintrc.js

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,3 @@
11
module.exports = {
2-
root: true,
3-
env: {
4-
es6: true,
5-
},
6-
parserOptions: {
7-
ecmaVersion: 2018,
8-
},
9-
extends: ['@sentry-internal/sdk'],
10-
ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**'],
11-
overrides: [
12-
{
13-
files: ['*.ts', '*.tsx', '*.d.ts'],
14-
parserOptions: {
15-
project: './tsconfig.json',
16-
},
17-
},
18-
{
19-
files: ['test/**'],
20-
rules: {
21-
'@typescript-eslint/no-explicit-any': 'off',
22-
'@typescript-eslint/no-non-null-assertion': 'off',
23-
},
24-
},
25-
],
26-
rules: {
27-
'max-lines': 'off',
28-
},
2+
extends: ['../../.eslintrc.js'],
293
};

packages/utils/src/instrument.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable max-lines */
12
/* eslint-disable @typescript-eslint/no-explicit-any */
23
/* eslint-disable @typescript-eslint/ban-types */
34
import { WrappedFunction } from '@sentry/types';

packages/utils/src/object.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable max-lines */
12
/* eslint-disable @typescript-eslint/no-explicit-any */
23
import { ExtendedError, WrappedFunction } from '@sentry/types';
34

0 commit comments

Comments
 (0)