Skip to content

Commit d3abf45

Browse files
authored
build(ember): Update ember test sinon usage (#8694)
One of a few steps to try to fix canary tests...
1 parent f833ab2 commit d3abf45

File tree

3 files changed

+150
-64
lines changed

3 files changed

+150
-64
lines changed

packages/ember/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"ember-maybe-import-regenerator": "~1.0.0",
6363
"ember-qunit": "~6.0.0",
6464
"ember-resolver": "~8.0.3",
65-
"ember-sinon-qunit": "~6.0.0",
65+
"ember-sinon-qunit": "7.1.4",
6666
"ember-source": "~4.8.0",
6767
"ember-source-channel-url": "~2.0.1",
6868
"ember-template-lint": "~4.16.1",
@@ -75,6 +75,7 @@
7575
"loader.js": "~4.7.0",
7676
"qunit": "~2.19.2",
7777
"qunit-dom": "~2.0.0",
78+
"sinon": "15.2.0",
7879
"webpack": "~5.74.0"
7980
},
8081
"engines": {

packages/ember/tests/test-helper.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
1-
import sinon from 'sinon';
21
import * as Sentry from '@sentry/browser';
3-
4-
/**
5-
* Stub Sentry init function before application is imported to avoid actually setting up Sentry and needing a DSN
6-
*/
7-
sinon.stub(Sentry, 'init');
8-
2+
import setupSinon from 'ember-sinon-qunit';
93
import Application from '../app';
104
import config from '../config/environment';
115
import { setApplication } from '@ember/test-helpers';
@@ -24,5 +18,7 @@ Sentry.addGlobalEventProcessor(event => {
2418

2519
setApplication(Application.create(config.APP));
2620

21+
setupSinon();
22+
2723
start();
2824
QUnit.config.ignoreGlobalErrors = true;

0 commit comments

Comments
 (0)