Skip to content

Commit d6cd5ca

Browse files
authored
test(remix): Add dependency resolution overrides to fix breaking Node compatibility changes in dependencies (#12793)
This PR fixes our broken Remix v1 @ Node 16 integration test. Over the weekend, the following transitive dependencies received minor and patch releases which removed support for EOL Node versions. - `glob` (isaacs/node-glob#596) - `lru-cache` (isaacs/node-lru-cache#340) - `jackspeack` (isaacs/jackspeak#13) IMO this, despite the dropped versions being EOL, is a breaking change and a major inconvenience for a lot of users. I added comments/opened issues with the request to revert the Node version drops and do it in a major version instead. We're by far not the only affected ones. As our tests show, at least everyone using Remix@1 on Node 16 will be broken by this. To fix, I added dependency resolutions, mostly scoped to specific packages that depend on one of the three packages. Global overrides for `glob` and `lru-cache` did not work because we have multiple dependencies depending on different major versions of said packages.
1 parent ecc95e7 commit d6cd5ca

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

packages/remix/test/integration/package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@
3636
"@sentry/utils": "file:../../../utils",
3737
"@vanilla-extract/css": "1.13.0",
3838
"@vanilla-extract/integration": "6.2.4",
39-
"@types/mime": "^3.0.0"
39+
"@types/mime": "^3.0.0",
40+
"@sentry/remix/glob": "<10.4.3",
41+
"jackspeak": "<3.4.1",
42+
"**/path-scurry/lru-cache": "10.2.0"
4043
},
4144
"engines": {
4245
"node": ">=14.18"

0 commit comments

Comments
 (0)