Skip to content

Commit d824691

Browse files
authored
Fix "Error: undefined" breadcrumbs (#681)
1 parent 8c7db8f commit d824691

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

src/raven.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,7 @@ Raven.prototype = {
12521252
this.captureBreadcrumb({
12531253
category: 'sentry',
12541254
message: exception
1255-
? (exception.type ? exception.type + ': ' : '') + exception.message
1255+
? (exception.type ? exception.type + ': ' : '') + exception.value
12561256
: data.message,
12571257
event_id: data.event_id,
12581258
level: data.level || 'error' // presume error unless specified

test/raven.test.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -648,6 +648,22 @@ describe('globals', function() {
648648
{ category: 'sentry', message: 'bar', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'error' },
649649
{ category: 'sentry', message: 'foo', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'warning' }
650650
]);
651+
652+
Raven._send({
653+
exception: {
654+
values: [{
655+
type: 'ReferenceError',
656+
value: 'foo is not defined'
657+
}]
658+
}
659+
});
660+
assert.deepEqual(Raven._breadcrumbs, [
661+
{ type: 'http', timestamp: 0.1, data: { method: 'POST', url: 'http://example.org/api/0/auth/' }},
662+
{ category: 'sentry', message: 'bar', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'error' },
663+
{ category: 'sentry', message: 'foo', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'warning' },
664+
{ category: 'sentry', message: 'ReferenceError: foo is not defined', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'error' }
665+
]);
666+
651667
});
652668

653669
it('should build a good data payload with a User', function() {

0 commit comments

Comments
 (0)