fix(utils): Fix XHR instrumentation early return (#9770)

mydea · web-flow · commit da73a7a5cc56 · 2023-12-07T10:39:28.000+01:00
This was introduced in #9542 😬 Ideally we could have a lint rule for this, but probably this is rather hard to do - so reminder to self to keep an eye out for this in the future! Closes #9747
diff --git a/packages/utils/src/instrument/xhr.ts b/packages/utils/src/instrument/xhr.ts
@@ -46,7 +46,7 @@ export function instrumentXHR(): void {
       const url = parseUrl(args[1]);
 
       if (!method || !url) {
-        return;
+        return originalOpen.apply(this, args);
       }
 
       this[SENTRY_XHR_DATA_KEY] = {
@@ -124,7 +124,7 @@ export function instrumentXHR(): void {
       const sentryXhrData = this[SENTRY_XHR_DATA_KEY];
 
       if (!sentryXhrData) {
-        return;
+        return originalSend.apply(this, args);
       }
 
       if (args[0] !== undefined) {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export function instrumentXHR(): void {`
`46`	`46`	`const url = parseUrl(args[1]);`
`47`	`47`
`48`	`48`	`if (!method \|\| !url) {`
`49`		`- return;`
	`49`	`+ return originalOpen.apply(this, args);`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`this[SENTRY_XHR_DATA_KEY] = {`
`@@ -124,7 +124,7 @@ export function instrumentXHR(): void {`
`124`	`124`	`const sentryXhrData = this[SENTRY_XHR_DATA_KEY];`
`125`	`125`
`126`	`126`	`if (!sentryXhrData) {`
`127`		`- return;`
	`127`	`+ return originalSend.apply(this, args);`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`if (args[0] !== undefined) {`