review comments

Author: s1gr1d

dev-packages/node-integration-tests/suites/tracing/redis-cache/test.ts

@@ -53,7 +53,7 @@ describe('redis cache auto instrumentation', () => {
           origin: 'auto.db.otel.redis',
           data: expect.objectContaining({
             'sentry.origin': 'auto.db.otel.redis',
-            'db.statement': 'ioredis-cache:test-key [1 other arguments]',
+            'db.statement': 'set ioredis-cache:test-key [1 other arguments]',
             'cache.key': 'ioredis-cache:test-key',
             'cache.item_size': 2,
             'network.peer.address': 'localhost',

packages/node/src/utils/redisCache.ts

@@ -54,8 +54,9 @@ export function getCacheKeySafely(cmdArgs: IORedisCommandArgs): string {
 /** Determines whether a redis operation should be considered as "cache operation" by checking if a key is prefixed.
  *  We only support certain commands (such as 'set', 'get', 'mget'). */
 export function shouldConsiderForCache(redisCommand: string, key: string, prefixes: string[]): boolean {
-  const lowercaseCommand = redisCommand.toLowerCase();
-  if (!SET_COMMANDS.includes(lowercaseCommand) && !GET_COMMANDS.includes(lowercaseCommand)) return false;
+  if (!getCacheOperation(redisCommand)) {
+    return false;
+  }
 
   return key.split(',').reduce((prev, key) => prev || keyHasPrefix(key, prefixes), false);
 }