Skip to content

Commit e4c0201

Browse files
committed
ci: Make E2E tests required & check for PRs against master
1 parent 1403e77 commit e4c0201

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

.github/workflows/build.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,21 @@ jobs:
181181
outputs:
182182
dependency_cache_key: ${{ steps.compute_lockfile_hash.outputs.hash }}
183183

184+
job_check_branches:
185+
name: Check PR branches
186+
needs: job_get_metadata
187+
runs-on: ubuntu-20.04
188+
if: github.event_name == 'pull_request'
189+
permissions:
190+
pull-requests: write
191+
steps:
192+
- name: PR is opened against master
193+
uses: mshick/add-pr-comment@v2
194+
if: github.ref == 'refs/heads/master' && github.head_ref != 'refs/heads/develop'
195+
with:
196+
message: |
197+
⚠️ This PR is opened against **master**. You probably want to open it against **develop**.
198+
184199
job_build:
185200
name: Build
186201
needs: [job_get_metadata, job_install_deps]
@@ -709,6 +724,7 @@ jobs:
709724
job_browser_playwright_tests,
710725
job_browser_integration_tests,
711726
job_remix_integration_tests,
727+
job_e2e_tests,
712728
]
713729
# Always run this, even if a dependent job failed
714730
if: always()

0 commit comments

Comments
 (0)