PR feedback

Author: mydea

packages/browser-integration-tests/suites/replay/largeMutations/fullSnapshotOnMutationsOver/init.js renamed to packages/browser-integration-tests/suites/replay/largeMutations/mutationLimit/init.js

@@ -5,7 +5,7 @@ window.Replay = new Sentry.Replay({
   flushMinDelay: 200,
   flushMaxDelay: 200,
   _experiments: {
-    fullSnapshotOnMutationsOver: 250,
+    mutationLimit: 250,
   },
 });
 

packages/browser-integration-tests/suites/replay/largeMutations/fullSnapshotOnMutationsOver/template.html renamed to packages/browser-integration-tests/suites/replay/largeMutations/mutationLimit/template.html

@@ -4,7 +4,7 @@ import { sentryTest } from '../../../../utils/fixtures';
 import { getReplayRecordingContent, shouldSkipReplayTest, waitForReplayRequest } from '../../../../utils/replayHelpers';
 
 sentryTest(
-  'handles large mutations with _experiments.fullSnapshotOnMutationsOver configured',
+  'handles large mutations with _experiments.mutationLimit configured',
   async ({ getLocalTestPath, page, forceFlushReplay }) => {
     if (shouldSkipReplayTest()) {
       sentryTest.skip();

packages/browser-integration-tests/suites/replay/largeMutations/fullSnapshotOnMutationsOver/test.ts renamed to packages/browser-integration-tests/suites/replay/largeMutations/mutationLimit/test.ts

@@ -828,11 +828,13 @@ export class ReplayContainer implements ReplayContainerInterface {
   private _onMutationHandler = (mutations: unknown[]): boolean => {
     const count = mutations.length;
 
-    const fullSnapshotOnMutationsOver = this._options._experiments.fullSnapshotOnMutationsOver || 0;
+    const mutationLimit = this._options._experiments.mutationLimit || 0;
+    const mutationBreadcrumbLimit = this._options._experiments.mutationBreadcrumbLimit || 1000;
+    const overMutationLimit = mutationLimit && count > mutationLimit;
 
     // Create a breadcrumb if a lot of mutations happen at the same time
     // We can show this in the UI as an information with potential performance improvements
-    if (count > 500 || (fullSnapshotOnMutationsOver && count > fullSnapshotOnMutationsOver)) {
+    if (count > mutationBreadcrumbLimit || overMutationLimit) {
       const breadcrumb = createBreadcrumb({
         category: 'replay.mutations',
         data: {
@@ -842,7 +844,7 @@ export class ReplayContainer implements ReplayContainerInterface {
       this._createCustomBreadcrumb(breadcrumb);
     }
 
-    if (fullSnapshotOnMutationsOver && count > fullSnapshotOnMutationsOver) {
+    if (overMutationLimit) {
       // We want to skip doing an incremental snapshot if there are too many mutations
       // Instead, we do a full snapshot
       this._triggerFullSnapshot(false);

packages/replay/src/replay.ts

@@ -110,7 +110,8 @@ export interface ReplayPluginOptions extends SessionOptions {
   _experiments: Partial<{
     captureExceptions: boolean;
     traceInternals: boolean;
-    fullSnapshotOnMutationsOver: number;
+    mutationLimit: number;
+    mutationBreadcrumbLimit: number;
   }>;
 }