fix: Retry-After header in node should be lower-case (#2779)

Author: kamilogorek

packages/browser/src/transports/fetch.ts

@@ -57,7 +57,12 @@ export class FetchTransport extends BaseTransport {
 
             if (status === Status.RateLimit) {
               const now = Date.now();
-              this._disabledUntil = new Date(now + parseRetryAfterHeader(now, response.headers.get('Retry-After')));
+              /**
+               * "The name is case-insensitive."
+               * https://developer.mozilla.org/en-US/docs/Web/API/Headers/get
+               */
+              const retryAfterHeader = response.headers.get('Retry-After');
+              this._disabledUntil = new Date(now + parseRetryAfterHeader(now, retryAfterHeader));
               logger.warn(`Too many requests, backing off till: ${this._disabledUntil}`);
             }
 

packages/browser/src/transports/xhr.ts

@@ -41,7 +41,12 @@ export class XHRTransport extends BaseTransport {
 
           if (status === Status.RateLimit) {
             const now = Date.now();
-            this._disabledUntil = new Date(now + parseRetryAfterHeader(now, request.getResponseHeader('Retry-After')));
+            /**
+             * "The search for the header name is case-insensitive."
+             * https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/getResponseHeader
+             */
+            const retryAfterHeader = request.getResponseHeader('Retry-After');
+            this._disabledUntil = new Date(now + parseRetryAfterHeader(now, retryAfterHeader));
             logger.warn(`Too many requests, backing off till: ${this._disabledUntil}`);
           }
 

packages/node/src/transports/base.ts

@@ -106,9 +106,13 @@ export abstract class BaseTransport implements Transport {
           } else {
             if (status === Status.RateLimit) {
               const now = Date.now();
-              let header = res.headers ? res.headers['Retry-After'] : '';
-              header = Array.isArray(header) ? header[0] : header;
-              this._disabledUntil = new Date(now + parseRetryAfterHeader(now, header));
+              /**
+               * "Key-value pairs of header names and values. Header names are lower-cased."
+               * https://nodejs.org/api/http.html#http_message_headers
+               */
+              let retryAfterHeader = res.headers ? res.headers['retry-after'] : '';
+              retryAfterHeader = Array.isArray(retryAfterHeader) ? retryAfterHeader[0] : retryAfterHeader;
+              this._disabledUntil = new Date(now + parseRetryAfterHeader(now, retryAfterHeader));
               logger.warn(`Too many requests, backing off till: ${this._disabledUntil}`);
             }