Skip to content

Commit e7c725c

Browse files
committed
pr feedback & new release docs
1 parent 4e2f0d4 commit e7c725c

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

docs/new-sdk-release-checklist.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ This page serves as a checklist of what to do when releasing a new SDK for the f
4747

4848
- [ ] Make sure it is added to `bundlePlugins.ts:makeTSPlugin` as `paths`, otherwise it will not be ES5 transpiled correctly for CDN builds.
4949

50+
- [ ] Make sure it is added to the [Verdaccio config](https://github.com/getsentry/sentry-javascript/blob/develop/packages/e2e-tests/verdaccio-config/config.yaml) for the E2E tests
51+
5052
## Cutting the Release
5153

5254
When you’re ready to make the first release, there are a couple of steps that need to be performed in the **correct order**. Note that you can prepare the PRs at any time but the **merging oder** is important:
@@ -56,7 +58,7 @@ When you’re ready to make the first release, there are a couple of steps that
5658
### Before the Release:
5759

5860
- [ ] 1) If not yet done, be sure to remove the `private: true` property from your SDK’s `package.json`. Additionally, ensure that `"publishConfig": {"access": "public"}` is set.
59-
- [ ] 2) Make sure that the new SDK is **not added** in`[craft.yml](https://github.com/getsentry/sentry-javascript/blob/master/.craft.yml)` as a target for the **Sentry release registry**\
61+
- [ ] 2) Make sure that the new SDK is **not added** in`[craft.yml](https://github.com/getsentry/sentry-javascript/blob/develop/.craft.yml)` as a target for the **Sentry release registry**\
6062
*Once this is added, craft will try to publish an entry in the next release which does not work and caused failed release runs in the past*
6163
- [ ] 3) Add an `npm` target in `craft.yml` for the new package. Make sure to insert it in the right place, after all the Sentry dependencies of your package but before packages that depend on your new package (if applicable).
6264
```yml
@@ -74,7 +76,7 @@ When you’re ready to make the first release, there are a couple of steps that
7476
You have to fork this repo and PR the files from your fork to the main repo \
7577
[Example PR](https://github.com/getsentry/sentry-release-registry/pull/80) from the Svelte SDK
7678
77-
- [ ] 2) Add an entry to `[craft.yml](https://github.com/getsentry/sentry-javascript/blob/master/.craft.yml)` to add releases of your SDK to the Sentry release registry \
79+
- [ ] 2) Add an entry to [craft.yml](https://github.com/getsentry/sentry-javascript/blob/develop/.craft.yml) to add releases of your SDK to the Sentry release registry \
7880
[Example PR](https://github.com/getsentry/sentry-javascript/pull/5547) from the Svelte SDK \
7981
*Subsequent releases will now be added automatically to the registry*
8082

packages/e2e-tests/verdaccio-config/config.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,12 @@ packages:
122122
unpublish: $all
123123
# proxy: npmjs # Don't proxy for E2E tests!
124124

125+
'@sentry/opentelemetry':
126+
access: $all
127+
publish: $all
128+
unpublish: $all
129+
# proxy: npmjs # Don't proxy for E2E tests!
130+
125131
'@sentry/react':
126132
access: $all
127133
publish: $all

0 commit comments

Comments
 (0)