Skip to content

Commit e856733

Browse files
committed
streamline log group better
1 parent 42d8aee commit e856733

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

dev-packages/size-limit-gh-action/index.mjs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,15 @@ async function run() {
8282
let baseWorkflowRun;
8383

8484
try {
85+
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
86+
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
8587
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
8688
...repo,
8789
artifactName: ARTIFACT_NAME,
8890
branch: comparisonBranch,
89-
workflowName: `${process.env.GITHUB_WORKFLOW || ''}`,
91+
workflowName
9092
});
93+
core.endGroup();
9194

9295
if (!artifacts) {
9396
throw new Error('No artifacts found');

dev-packages/size-limit-gh-action/utils/getArtifactsForBranchAndWorkflow.mjs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ const DEFAULT_PAGE_LIMIT = 10;
1818
* support downloading artifacts from other workflows
1919
*/
2020
export async function getArtifactsForBranchAndWorkflow(octokit, { owner, repo, workflowName, branch, artifactName }) {
21-
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${branch}"`);
22-
2321
let repositoryWorkflow = null;
2422

2523
// For debugging
@@ -51,7 +49,6 @@ export async function getArtifactsForBranchAndWorkflow(octokit, { owner, repo, w
5149
', ',
5250
)}`,
5351
);
54-
core.endGroup();
5552
return null;
5653
}
5754

@@ -70,7 +67,6 @@ export async function getArtifactsForBranchAndWorkflow(octokit, { owner, repo, w
7067
})) {
7168
if (!response.data.length) {
7269
core.warning(`Workflow ${workflow_id} not found in branch ${branch}`);
73-
core.endGroup();
7470
return null;
7571
}
7672

@@ -107,7 +103,6 @@ export async function getArtifactsForBranchAndWorkflow(octokit, { owner, repo, w
107103
const foundArtifact = artifacts.find(({ name }) => name === artifactName);
108104
if (foundArtifact) {
109105
core.info(`Found suitable artifact: ${foundArtifact.url}`);
110-
core.endGroup();
111106
return {
112107
artifact: foundArtifact,
113108
workflowRun,
@@ -121,7 +116,6 @@ export async function getArtifactsForBranchAndWorkflow(octokit, { owner, repo, w
121116

122117
if (currentPage > DEFAULT_MAX_PAGES) {
123118
core.warning(`Workflow ${workflow_id} not found in branch: ${branch}`);
124-
core.endGroup();
125119
return null;
126120
}
127121

0 commit comments

Comments
 (0)