Skip to content

Commit e869d73

Browse files
author
Luca Forstner
committed
Fix import structure
1 parent 598f53d commit e869d73

File tree

7 files changed

+12
-17
lines changed

7 files changed

+12
-17
lines changed

packages/core/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ export { hasTracingEnabled } from './utils/hasTracingEnabled';
5656
export { isSentryRequestUrl } from './utils/isSentryRequestUrl';
5757
export { DEFAULT_ENVIRONMENT } from './constants';
5858
export { ModuleMetadata } from './integrations/metadata';
59+
export { RequestData } from './integrations/requestdata';
5960
import * as Integrations from './integrations';
6061

6162
export { Integrations };

packages/core/src/integrations/requestdata.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
1-
// TODO (v8 or v9): Whenever this becomes a default integration for `@sentry/browser`, move this to `@sentry/core`. For
2-
// now, we leave it in `@sentry/integrations` so that it doesn't contribute bytes to our CDN bundles.
3-
41
import type { Event, EventProcessor, Hub, Integration, PolymorphicRequest, Transaction } from '@sentry/types';
5-
import { extractPathForTransaction } from '@sentry/utils';
6-
7-
import type { AddRequestDataToEventOptions, TransactionNamingScheme } from '../../../node/src/requestdata';
8-
import { addRequestDataToEvent } from '../../../node/src/requestdata';
2+
import type { AddRequestDataToEventOptions, TransactionNamingScheme } from '@sentry/utils';
3+
import { addRequestDataToEvent, extractPathForTransaction } from '@sentry/utils';
94

105
export type RequestDataIntegrationOptions = {
116
/**
@@ -59,7 +54,7 @@ export class RequestData implements Integration {
5954
/**
6055
* @inheritDoc
6156
*/
62-
public name: string = RequestData.id;
57+
public name: string;
6358

6459
/**
6560
* Function for adding request data to event. Defaults to `addRequestDataToEvent` from `@sentry/node` for now, but
@@ -74,6 +69,7 @@ export class RequestData implements Integration {
7469
* @inheritDoc
7570
*/
7671
public constructor(options: RequestDataIntegrationOptions = {}) {
72+
this.name = RequestData.id;
7773
this._addRequestData = addRequestDataToEvent;
7874
this._options = {
7975
...DEFAULT_OPTIONS,

packages/node/src/handlers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import {
1515
addRequestDataToTransaction,
1616
dropUndefinedKeys,
1717
extractPathForTransaction,
18+
extractRequestData,
1819
isString,
1920
isThenable,
2021
logger,
@@ -24,7 +25,6 @@ import {
2425
import type * as http from 'http';
2526

2627
import type { NodeClient } from './client';
27-
import { extractRequestData } from './requestdata';
2828
// TODO (v8 / XXX) Remove this import
2929
import type { ParseRequestOptions } from './requestDataDeprecated';
3030
import { isAutoSessionTrackingEnabled } from './sdk';

packages/node/src/index.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ export type {
1818
Transaction,
1919
User,
2020
} from '@sentry/types';
21-
export type { AddRequestDataToEventOptions } from '@sentry/utils';
21+
export type { AddRequestDataToEventOptions, TransactionNamingScheme } from '@sentry/utils';
2222

23-
export type { TransactionNamingScheme } from './requestdata';
2423
export type { NodeOptions } from './types';
2524

2625
export {
@@ -72,7 +71,7 @@ export { autoDiscoverNodePerformanceMonitoringIntegrations } from './tracing';
7271
export { NodeClient } from './client';
7372
export { makeNodeTransport } from './transports';
7473
export { defaultIntegrations, init, defaultStackParser, getSentryRelease } from './sdk';
75-
export { addRequestDataToEvent, DEFAULT_USER_INCLUDES, extractRequestData } from './requestdata';
74+
export { addRequestDataToEvent, DEFAULT_USER_INCLUDES, extractRequestData } from '@sentry/utils';
7675
export { deepReadDirSync } from './utils';
7776
export { getModuleFromFilename } from './module';
7877
export { enableAnrDetection } from './anr';

packages/node/src/integrations/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ export { OnUnhandledRejection } from './onunhandledrejection';
55
export { Modules } from './modules';
66
export { ContextLines } from './contextlines';
77
export { Context } from './context';
8-
export { RequestData } from './requestdata';
8+
export { RequestData } from '@sentry/core';
99
export { LocalVariables } from './localvariables';
1010
export { Undici } from './undici';

packages/node/src/requestDataDeprecated.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77
/* eslint-disable deprecation/deprecation */
88
/* eslint-disable @typescript-eslint/no-explicit-any */
99
import type { Event, ExtractedNodeRequestData, PolymorphicRequest } from '@sentry/types';
10-
11-
import type { AddRequestDataToEventOptions } from './requestdata';
12-
import { addRequestDataToEvent, extractRequestData as _extractRequestData } from './requestdata';
10+
import type { AddRequestDataToEventOptions } from '@sentry/utils';
11+
import { addRequestDataToEvent, extractRequestData as _extractRequestData } from '@sentry/utils';
1312

1413
/**
1514
* @deprecated `Handlers.ExpressRequest` is deprecated and will be removed in v8. Use `PolymorphicRequest` instead.

packages/utils/src/requestdata.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const DEFAULT_INCLUDES = {
1818
user: true,
1919
};
2020
const DEFAULT_REQUEST_INCLUDES = ['cookies', 'data', 'headers', 'method', 'query_string', 'url'];
21-
const DEFAULT_USER_INCLUDES = ['id', 'username', 'email'];
21+
export const DEFAULT_USER_INCLUDES = ['id', 'username', 'email'];
2222

2323
type InjectedNodeDeps = {
2424
cookie: {

0 commit comments

Comments
 (0)