Skip to content

Commit ea847d1

Browse files
author
Luca Forstner
authored
ci: Don't fail profiling bindings job on cache miss (#13464)
1 parent 5b9d3bb commit ea847d1

File tree

2 files changed

+11
-22
lines changed

2 files changed

+11
-22
lines changed

.github/workflows/build.yml

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,31 +1418,29 @@ jobs:
14181418
with:
14191419
ref: ${{ env.HEAD_COMMIT }}
14201420

1421+
- name: Setup Node
1422+
uses: actions/setup-node@v4
1423+
with:
1424+
node-version: ${{ matrix.node }}
1425+
14211426
- name: Restore dependency cache
14221427
uses: actions/cache/restore@v4
14231428
id: restore-dependencies
14241429
with:
14251430
path: ${{ env.CACHED_DEPENDENCY_PATHS }}
14261431
key: ${{ needs.job_build.outputs.dependency_cache_key }}
14271432
enableCrossOsArchive: true
1428-
fail-on-cache-miss: true
14291433

1430-
- name: Restore build cache
1431-
uses: actions/cache/restore@v4
1432-
id: restore-build
1433-
with:
1434-
path: ${{ env.CACHED_BUILD_PATHS }}
1435-
key: ${{ needs.job_build.outputs.dependency_cache_key }}
1436-
enableCrossOsArchive: true
1437-
fail-on-cache-miss: true
1434+
- name: Install dependencies
1435+
env:
1436+
SKIP_PLAYWRIGHT_BROWSER_INSTALL: "1"
1437+
if: steps.restore-dependencies.outputs.cache-hit != 'true'
1438+
run: yarn install --ignore-engines --frozen-lockfile
14381439

14391440
- name: Configure safe directory
14401441
run: |
14411442
git config --global --add safe.directory "*"
14421443
1443-
- name: Install yarn
1444-
run: npm i -g [email protected] --force
1445-
14461444
- name: Increase yarn network timeout on Windows
14471445
if: contains(matrix.os, 'windows')
14481446
run: yarn config set network-timeout 600000 -g
@@ -1454,15 +1452,6 @@ jobs:
14541452
with:
14551453
python-version: '3.8.10'
14561454

1457-
- name: Setup Node
1458-
uses: actions/setup-node@v4
1459-
with:
1460-
node-version: ${{ matrix.node }}
1461-
1462-
- name: Install Dependencies
1463-
if: steps.restore-dependencies.outputs.cache-hit != 'true'
1464-
run: yarn install --frozen-lockfile --ignore-engines --ignore-scripts
1465-
14661455
- name: Setup (arm64| ${{ contains(matrix.container, 'alpine') && 'musl' || 'glibc' }})
14671456
if: matrix.arch == 'arm64' && !contains(matrix.container, 'alpine') && matrix.target_platform != 'darwin'
14681457
run: |

dev-packages/browser-integration-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"private": true,
1010
"scripts": {
1111
"clean": "rimraf -g suites/**/dist loader-suites/**/dist tmp",
12-
"install-browsers": "npx playwright install --with-deps",
12+
"install-browsers": "[[ -z \"$SKIP_PLAYWRIGHT_BROWSER_INSTALL\" ]] && yarn install-browsers || echo 'Skipping browser installation'",
1313
"lint": "eslint . --format stylish",
1414
"fix": "eslint . --format stylish --fix",
1515
"type-check": "tsc",

0 commit comments

Comments
 (0)