Skip to content

Commit eaae7b0

Browse files
committed
add tests for node http request headers
1 parent dcc025c commit eaae7b0

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

packages/node/test/integrations/http.test.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,21 +64,23 @@ describe('tracing', () => {
6464
expect((spans[0] as Transaction).name).toEqual('dogpark');
6565
});
6666

67-
it('attaches the sentry-trace header to outgoing non-sentry requests', async () => {
67+
it('attaches tracing headers to outgoing non-sentry requests', async () => {
6868
nock('http://dogs.are.great')
6969
.get('/')
7070
.reply(200);
7171

7272
createTransactionOnScope();
7373

7474
const request = http.get('http://dogs.are.great/');
75-
const sentryTraceHeader = request.getHeader('sentry-trace') as string;
75+
const sentryTraceHeader = request.getHeader('sentry-trace');
76+
const tracestateHeader = request.getHeader('tracestate');
7677

7778
expect(sentryTraceHeader).toBeDefined();
78-
expect(TRACEPARENT_REGEXP.test(sentryTraceHeader)).toBe(true);
79+
expect(tracestateHeader).toBeDefined();
80+
expect(TRACEPARENT_REGEXP.test(sentryTraceHeader as string)).toBe(true);
7981
});
8082

81-
it("doesn't attach the sentry-trace header to outgoing sentry requests", () => {
83+
it("doesn't attach tracing headers to outgoing sentry requests", () => {
8284
nock('http://squirrelchasers.ingest.sentry.io')
8385
.get('/api/12312012/store/')
8486
.reply(200);
@@ -87,7 +89,9 @@ describe('tracing', () => {
8789

8890
const request = http.get('http://squirrelchasers.ingest.sentry.io/api/12312012/store/');
8991
const sentryTraceHeader = request.getHeader('sentry-trace');
92+
const tracestateHeader = request.getHeader('tracestate');
9093

9194
expect(sentryTraceHeader).not.toBeDefined();
95+
expect(tracestateHeader).not.toBeDefined();
9296
});
9397
});

0 commit comments

Comments
 (0)