more flaky

Author: mydea

packages/browser-integration-tests/suites/replay/errors/errorsInSession/test.ts

@@ -14,8 +14,8 @@ for (let i = 0; i < 100; i++) {
   sentryTest(
     `[session-mode] replay event should contain an error id of an error that occurred during session recording RUN ${i}`,
     async ({ getLocalTestPath, page, browserName, forceFlushReplay }) => {
-      // TODO(replay): This is flakey on firefox where clicks are flakey
-      if (shouldSkipReplayTest() || browserName === 'firefox') {
+      // Skipping this in firefox/webkit because it is flakey there
+      if (shouldSkipReplayTest() || ['firefox', 'webkit'].includes(browserName)) {
         sentryTest.skip();
       }
 
@@ -88,8 +88,8 @@ for (let i = 0; i < 100; i++) {
   sentryTest(
     `[session-mode] replay event should not contain an error id of a dropped error while recording RUN ${i}`,
     async ({ getLocalTestPath, page, forceFlushReplay, browserName }) => {
-      // TODO(replay): This is flakey on firefox where clicks are flakey
-      if (shouldSkipReplayTest() || browserName === 'firefox') {
+      // Skipping this in firefox/webkit because it is flakey there
+      if (shouldSkipReplayTest() || ['firefox', 'webkit'].includes(browserName)) {
         sentryTest.skip();
       }
 

packages/browser-integration-tests/suites/replay/requests/test.ts

@@ -5,10 +5,10 @@ import { expectedFetchPerformanceSpan, expectedXHRPerformanceSpan } from '../../
 import { getReplayRecordingContent, shouldSkipReplayTest, waitForReplayRequest } from '../../../utils/replayHelpers';
 
 sentryTest('replay recording should contain fetch request span', async ({ getLocalTestPath, page, browserName }) => {
-  // For some reason, observing and waiting for requests in firefox is extremely flaky.
-  // We therefore skip this test for firefox and only test on chromium/webkit.
+  // For some reason, observing and waiting for requests in firefox/webkit is extremely flaky.
+  // We therefore skip this test for firefox and only test on chromium.
   // Possibly related: https://github.com/microsoft/playwright/issues/11390
-  if (shouldSkipReplayTest() || browserName === 'firefox') {
+  if (shouldSkipReplayTest() || ['firefox', 'webkit'].includes(browserName)) {
     sentryTest.skip();
   }
 
@@ -48,9 +48,9 @@ sentryTest('replay recording should contain fetch request span', async ({ getLoc
 });
 
 sentryTest('replay recording should contain XHR request span', async ({ getLocalTestPath, page, browserName }) => {
-  // For some reason, observing and waiting for requests in firefox is extremely flaky.
-  // We therefore skip this test for firefox and only test on chromium/webkit.
-  if (shouldSkipReplayTest() || browserName === 'firefox') {
+  // For some reason, observing and waiting for requests in firefox/webkit is extremely flaky.
+  // We therefore skip this test for firefox and only test on chromium.
+  if (shouldSkipReplayTest() || ['firefox', 'webkit'].includes(browserName)) {
     sentryTest.skip();
   }