fixes

mydea · mydea · commit ef733c053487 · 2023-08-17T16:52:24.000+02:00
diff --git a/packages/browser-integration-tests/suites/replay/bufferModeReload/template.html b/packages/browser-integration-tests/suites/replay/bufferModeReload/template.html
@@ -5,6 +5,6 @@
   </head>
   <body>
     <button onclick="console.log('Test log 1')" id="button1">Click me</button>
-    <button onclick="window.doesNotExist()" id="buttonError">Click me</button>
+    <button onclick="Sentry.captureException('test error')" id="buttonError">Click me</button>
   </body>
 </html>
diff --git a/packages/replay/src/replay.ts b/packages/replay/src/replay.ts
@@ -243,15 +243,9 @@ export class ReplayContainer implements ReplayContainerInterface {
       return;
     }
 
-    let recordingMode: ReplayRecordingMode = 'session';
-
     // If segmentId > 0, it means we've previously already captured this session
     // In this case, we still want to continue in `session` recording mode
-    if (this.session.sampled === 'buffer' && this.session.segmentId === 0) {
-      recordingMode = 'buffer';
-    }
-
-    this.recordingMode = recordingMode;
+    this.recordingMode = this.session.sampled === 'buffer' && this.session.segmentId === 0 ? 'buffer' : 'session';
 
     logInfoNextTick(
       `[Replay] Starting replay in ${this.recordingMode} mode`,
