ref: Update wrap method to hide internal sentry flags

Author: kamilogorek

CHANGELOG.md

@@ -4,7 +4,9 @@
 
 ## 5.0.0
 
-- [node] fix: Events created from exception shouldnt have top-level message attribute
+- **breaking** [node] fix: Events created from exception shouldnt have top-level message attribute
+- [utils] ref: Update wrap method to hide internal sentry flags
+- [utils] fix: Make internal Sentry flags non-enumerable in fill util
 
 ## 4.5.3
 

packages/browser/src/integrations/helpers.ts

@@ -113,13 +113,26 @@ export function wrap(
     }
   } catch (_oO) {} // tslint:disable-line:no-empty
 
+  fn.prototype = fn.prototype || {};
   sentryWrapped.prototype = fn.prototype;
-  fn.__sentry_wrapped__ = sentryWrapped;
+
+  Object.defineProperty(fn, '__sentry_wrapped__', {
+    enumerable: false,
+    value: sentryWrapped,
+  });
 
   // Signal that this function has been wrapped/filled already
   // for both debugging and to prevent it to being wrapped/filled twice
-  sentryWrapped.__sentry__ = true;
-  sentryWrapped.__sentry_original__ = fn;
+  Object.defineProperties(sentryWrapped, {
+    __sentry__: {
+      enumerable: false,
+      value: true,
+    },
+    __sentry_original__: {
+      enumerable: false,
+      value: fn,
+    },
+  });
 
   return sentryWrapped;
 }

packages/browser/test/integrations/helpers.test.ts

@@ -179,4 +179,21 @@ describe('wrap()', () => {
       expect(error.message).equal('boom');
     }
   });
+
+  it.only('internal flags shouldnt be enumerable', () => {
+    const fn = (() => 1337) as SentryWrappedFunction;
+    const wrapped = wrap(fn);
+
+    // Shouldn't show up in iteration
+    expect(Object.keys(fn)).to.not.include('__sentry__');
+    expect(Object.keys(fn)).to.not.include('__sentry_original__');
+    expect(Object.keys(fn)).to.not.include('__sentry_wrapped__');
+    expect(Object.keys(wrapped)).to.not.include('__sentry__');
+    expect(Object.keys(wrapped)).to.not.include('__sentry_original__');
+    expect(Object.keys(wrapped)).to.not.include('__sentry_wrapped__');
+    // But should be accessible directly
+    expect(wrapped.__sentry__).to.equal(true);
+    expect(wrapped.__sentry_original__).to.equal(fn);
+    expect(fn.__sentry_wrapped__).to.equal(wrapped);
+  });
 });