Skip to content

Commit f0a4463

Browse files
committed
update node integration tests & e2e tests to work
1 parent 2fe04af commit f0a4463

File tree

71 files changed

+53
-1167
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+53
-1167
lines changed

dev-packages/e2e-tests/test-applications/node-exports-test-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"test:assert": "pnpm test"
1313
},
1414
"dependencies": {
15-
"@sentry/node": "latest || *",
15+
"@sentry/node-experimental": "latest || *",
1616
"@sentry/sveltekit": "latest || *",
1717
"@sentry/remix": "latest || *",
1818
"@sentry/astro": "latest || *",

dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as SentryAstro from '@sentry/astro';
22
import * as SentryBun from '@sentry/bun';
33
import * as SentryNextJs from '@sentry/nextjs';
4-
import * as SentryNode from '@sentry/node';
4+
import * as SentryNode from '@sentry/node-experimental';
55
import * as SentryRemix from '@sentry/remix';
66
import * as SentryServerless from '@sentry/serverless';
77
import * as SentrySvelteKit from '@sentry/sveltekit';

dev-packages/e2e-tests/test-applications/node-express-app/src/app.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@ Sentry.init({
2222
const app = express();
2323
const port = 3030;
2424

25-
app.use(Sentry.Handlers.requestHandler());
26-
app.use(Sentry.Handlers.tracingHandler());
27-
2825
app.get('/test-success', function (req, res) {
2926
res.send({ version: 'v1' });
3027
});
@@ -73,7 +70,7 @@ app.get('/test-local-variables-caught', function (req, res) {
7370
res.send({ exceptionId, randomVariableToRecord });
7471
});
7572

76-
app.use(Sentry.Handlers.errorHandler());
73+
Sentry.setupExpressErrorHandler(app);
7774

7875
// @ts-ignore
7976
app.use(function onError(err, req, res, next) {

dev-packages/e2e-tests/test-applications/node-hapi-app/src/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Sentry.init({
1010
environment: 'qa', // dynamic sampling bias to keep transactions
1111
dsn: process.env.E2E_TEST_DSN,
1212
includeLocalVariables: true,
13-
integrations: [Sentry.hapiIntegration({ server })],
1413
debug: true,
1514
tunnel: `http://localhost:3031/`, // proxy server
1615
tracesSampleRate: 1,
@@ -56,6 +55,7 @@ const init = async () => {
5655

5756
(async () => {
5857
init();
58+
await Sentry.setupHapiErrorHandler(server);
5959
await server.start();
6060
console.log('Server running on %s', server.info.uri);
6161
})();

dev-packages/node-integration-tests/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,9 @@
1616
"build:types": "tsc -p tsconfig.types.json",
1717
"clean": "rimraf -g **/node_modules && run-p clean:script",
1818
"clean:script": "node scripts/clean.js",
19-
"prisma:init": "(cd suites/tracing/prisma-orm && ts-node ./setup.ts)",
20-
"prisma:init:new": "(cd suites/tracing-new/prisma-orm && ts-node ./setup.ts)",
2119
"lint": "eslint . --format stylish",
2220
"fix": "eslint . --format stylish --fix",
2321
"type-check": "tsc",
24-
"pretest": "run-s --silent prisma:init prisma:init:new",
2522
"test": "ts-node ./utils/run-tests.ts",
2623
"jest": "jest --config ./jest.config.js",
2724
"test:watch": "yarn test --watch"

dev-packages/node-integration-tests/suites/express/handle-error/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import express from 'express';
44

55
const app = express();

dev-packages/node-integration-tests/suites/express/multiple-routers/common-infix-parameterized/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/express/multiple-routers/common-infix/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-parameterized-reverse/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-parameterized/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-same-length-parameterized copy/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-same-length-parameterized/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/express/multiple-routers/complex-router/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import express from 'express';
44

55
const app = express();

dev-packages/node-integration-tests/suites/express/multiple-routers/middle-layer-parameterized/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import express from 'express';
44

55
const app = express();

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-header-out/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import http from 'http';
22
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
3-
import * as Sentry from '@sentry/node';
3+
import * as Sentry from '@sentry/node-experimental';
44
import cors from 'cors';
55
import express from 'express';
66

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-other-vendors-with-sentry-entries/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as http from 'http';
22
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
3-
import * as Sentry from '@sentry/node';
3+
import * as Sentry from '@sentry/node-experimental';
44
import cors from 'cors';
55
import express from 'express';
66

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-other-vendors/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import http from 'http';
22
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
3-
import * as Sentry from '@sentry/node';
3+
import * as Sentry from '@sentry/node-experimental';
44
import cors from 'cors';
55
import express from 'express';
66

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-transaction-name/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import http from 'http';
22
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
33
import { SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
4-
import * as Sentry from '@sentry/node';
4+
import * as Sentry from '@sentry/node-experimental';
55
import cors from 'cors';
66
import express from 'express';
77

dev-packages/node-integration-tests/suites/express/sentry-trace/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import http from 'http';
22
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
3-
import * as Sentry from '@sentry/node';
3+
import * as Sentry from '@sentry/node-experimental';
44
import cors from 'cors';
55
import express from 'express';
66

dev-packages/node-integration-tests/suites/express/tracing/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
2-
import * as Sentry from '@sentry/node';
2+
import * as Sentry from '@sentry/node-experimental';
33
import cors from 'cors';
44
import express from 'express';
55

dev-packages/node-integration-tests/suites/public-api/OnUncaughtException/mimic-native-behaviour-additional-listener-test-script.js

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,11 @@ const Sentry = require('@sentry/node');
22

33
Sentry.init({
44
dsn: 'https://[email protected]/1337',
5-
integrations: integrations => {
6-
return integrations.map(integration => {
7-
if (integration.name === 'OnUncaughtException') {
8-
return new Sentry.Integrations.OnUncaughtException({
9-
exitEvenIfOtherHandlersAreRegistered: false,
10-
});
11-
} else {
12-
return integration;
13-
}
14-
});
15-
},
5+
integrations: [
6+
Sentry.onUncaughtExceptionIntegration({
7+
exitEvenIfOtherHandlersAreRegistered: false,
8+
}),
9+
],
1610
});
1711

1812
process.on('uncaughtException', () => {

dev-packages/node-integration-tests/suites/public-api/OnUncaughtException/mimic-native-behaviour-no-additional-listener-test-script.js

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,11 @@ const Sentry = require('@sentry/node');
22

33
Sentry.init({
44
dsn: 'https://[email protected]/1337',
5-
integrations: integrations => {
6-
return integrations.map(integration => {
7-
if (integration.name === 'OnUncaughtException') {
8-
return new Sentry.Integrations.OnUncaughtException({
9-
exitEvenIfOtherHandlersAreRegistered: false,
10-
});
11-
} else {
12-
return integration;
13-
}
14-
});
15-
},
5+
integrations: [
6+
Sentry.onUncaughtExceptionIntegration({
7+
exitEvenIfOtherHandlersAreRegistered: false,
8+
}),
9+
],
1610
});
1711

1812
setTimeout(() => {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Sentry.startSpan({ name: 'root_span' }, () => {
1212
Sentry.startSpan(
1313
{
1414
name: 'span_1',
15-
data: {
15+
attributes: {
1616
foo: 'bar',
1717
baz: [1, 2, 3],
1818
},
@@ -25,7 +25,7 @@ Sentry.startSpan({ name: 'root_span' }, () => {
2525

2626
Sentry.startSpan({ name: 'span_3' }, () => {
2727
// span_4 is the child of span_3 but doesn't finish.
28-
Sentry.startInactiveSpan({ name: 'span_4', data: { qux: 'quux' } });
28+
Sentry.startInactiveSpan({ name: 'span_4', attributes: { qux: 'quux' } });
2929

3030
// span_5 is another child of span_3 but finishes.
3131
Sentry.startSpan({ name: 'span_5' }, () => undefined);

dev-packages/node-integration-tests/suites/sessions/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable no-console */
22
import type { SessionFlusher } from '@sentry/core';
3-
import * as Sentry from '@sentry/node';
3+
import * as Sentry from '@sentry/node-experimental';
44
import express from 'express';
55

66
const app = express();

dev-packages/node-integration-tests/suites/tracing-new/apollo-graphql/scenario.ts

Lines changed: 0 additions & 36 deletions
This file was deleted.

dev-packages/node-integration-tests/suites/tracing-new/apollo-graphql/test.ts

Lines changed: 0 additions & 33 deletions
This file was deleted.

dev-packages/node-integration-tests/suites/tracing-new/auto-instrument/mongodb/scenario.ts

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)