Skip to content

Commit f228b8d

Browse files
committed
fix comments
1 parent f3d196b commit f228b8d

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

packages/core/src/tracing/trace.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,6 @@ function createChildSpanOrTransaction({
250250
traceId,
251251
parentSpanId,
252252
parentSampled: sampled,
253-
// TODO: We should probably only set this if we know we are continuing a trace
254-
// For now, there isn't really a way to know this from in here, though...
255253
...spanContext,
256254
});
257255

@@ -260,13 +258,6 @@ function createChildSpanOrTransaction({
260258
}
261259
}
262260

263-
// TODO v8: Technically `startTransaction` can return undefined, which is not reflected by the types
264-
// This happens if tracing extensions have not been added
265-
// In this case, we just want to return a non-recording span
266-
if (!span) {
267-
return new SentryNonRecordingSpan();
268-
}
269-
270261
setCapturedScopesOnSpan(span, scope, isolationScope);
271262

272263
return span;

0 commit comments

Comments
 (0)