Skip to content

Commit f25a28c

Browse files
committed
update comment, fix test
1 parent 36d34b1 commit f25a28c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/feedback/src/util/sendFeedbackRequest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export async function sendFeedbackRequest({
109109
return response;
110110
}
111111

112-
// If the status code is invalid, we want to immediately stop & not retry
112+
// Require valid status codes, otherwise can assume feedback was not sent successfully
113113
if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
114114
throw new Error('Unable to send Feedback');
115115
}

packages/feedback/test/widget/createWidget.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ describe('createWidget', () => {
166166
});
167167

168168
(sendFeedbackRequest as jest.Mock).mockImplementation(() => {
169-
return false;
169+
throw new Error('Unable to send feedback');
170170
});
171171
widget.actor?.el?.dispatchEvent(new Event('click'));
172172

0 commit comments

Comments
 (0)