Skip to content

Commit f46e8f1

Browse files
committed
fix array stuff
1 parent fb6b86f commit f46e8f1

File tree

4 files changed

+13
-14
lines changed

4 files changed

+13
-14
lines changed

packages/browser/src/transports/base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export abstract class BaseTransport implements Transport {
138138
quantity: outcomes[key],
139139
};
140140
// TODO: Improve types on discarded_events to get rid of cast
141-
}) as Array<ClientReport['discarded_events']>;
141+
}) as ClientReport['discarded_events'];
142142
const envelope = createClientReportEnvelope(discardedEvents, this._api.tunnel && dsnToString(this._api.dsn));
143143

144144
try {

packages/types/src/clientreport.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ import { Outcome } from './transport';
33

44
export type ClientReport = {
55
timestamp: number;
6-
discarded_events: { reason: Outcome; category: SentryRequestType; quantity: number };
6+
discarded_events: Array<{ reason: Outcome; category: SentryRequestType; quantity: number }>;
77
};

packages/types/src/envelope.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export type UserFeedbackItem = BaseEnvelopeItem<UserFeedbackItemHeaders, UserFee
3838
export type SessionItem =
3939
| BaseEnvelopeItem<SessionItemHeaders, Session>
4040
| BaseEnvelopeItem<SessionAggregatesItemHeaders, SessionAggregates>;
41-
export type ClientReportItem = BaseEnvelopeItem<ClientReportItemHeaders, Array<ClientReport>>;
41+
export type ClientReportItem = BaseEnvelopeItem<ClientReportItemHeaders, ClientReport>;
4242

4343
type EventEnvelopeHeaders = { event_id: string; sent_at: string };
4444
type SessionEnvelopeHeaders = { sent_at: string };

packages/utils/src/clientreport.ts

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ClientReport, ClientReportEnvelope } from '@sentry/types';
1+
import { ClientReport, ClientReportEnvelope, ClientReportItem } from '@sentry/types';
22

33
import { createEnvelope } from './envelope';
44
import { dateTimestampInSeconds } from './time';
@@ -9,17 +9,16 @@ import { dateTimestampInSeconds } from './time';
99
* @param dsn A DSN that can be set on the header. Optional.
1010
*/
1111
export function createClientReportEnvelope(
12-
discarded_events: Array<ClientReport['discarded_events']>,
12+
discarded_events: ClientReport['discarded_events'],
1313
dsn?: string,
1414
timestamp?: number,
1515
): ClientReportEnvelope {
16-
return createEnvelope<ClientReportEnvelope>(dsn ? { dsn } : {}, [
17-
[
18-
{ type: 'client_report' },
19-
{
20-
timestamp: timestamp || dateTimestampInSeconds(),
21-
discarded_events,
22-
},
23-
],
24-
]);
16+
const clientReportItem: ClientReportItem = [
17+
{ type: 'client_report' },
18+
{
19+
timestamp: timestamp || dateTimestampInSeconds(),
20+
discarded_events,
21+
},
22+
];
23+
return createEnvelope<ClientReportEnvelope>(dsn ? { dsn } : {}, [clientReportItem]);
2524
}

0 commit comments

Comments
 (0)