move json parse into storage interface

Author: billyvg

packages/browser/src/client.ts

@@ -129,11 +129,25 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
     }
 
     return {
-      get(key: string) {
-        return localStorage.getItem(getKey(key));
+      get(key: string): unknown {
+        const value = WINDOW.localStorage.getItem(getKey(key));
+
+        if (value === null) {
+          return value;
+        }
+
+        try {
+          return JSON.parse(value);
+        } catch {
+          return null;
+        }
       },
-      set(key: string, value: string) {
-        return localStorage.setItem(getKey(key), value);
+      set(key: string, value: any): void {
+        try {
+          WINDOW.localStorage.setItem(getKey(key), JSON.stringify(value));
+        } catch {
+          DEBUG_BUILD && logger.error('Unable to serialize configuration and save to localStorage');
+        }
       },
     };
   }

packages/core/src/remoteconfig.ts

@@ -30,7 +30,7 @@ export function remoteConfig({
     // Use cached configuration if it exists
     const cachedValue = storage.get(defaultConfigName);
     if (cachedValue) {
-      _activeConfig = JSON.parse(cachedValue);
+      _activeConfig = cachedValue;
       _source = 'CACHED';
       _state = 'INITIALIZED';
     }
@@ -67,7 +67,7 @@ export function remoteConfig({
             _pendingConfig = data;
             _hasUpdate = true;
 
-            storage.set(defaultConfigName, JSON.stringify(data));
+            storage.set(defaultConfigName, data);
             storage.set(`${defaultConfigName}_lastFetch`, +_lastFetch);
             // _state = "SUCCESS";
             resolve();