test(e2e/aws-lambda-layer): Rename test app and improve lambda function

Author: Lms24

.github/workflows/build.yml

@@ -993,7 +993,7 @@ jobs:
           [
             'angular-17',
             'angular-18',
-            'aws-lambda-layer',
+            'aws-lambda-layer-cjs',
             'cloudflare-astro',
             'node-express',
             'create-react-app',

dev-packages/e2e-tests/test-applications/aws-lambda-layer/.npmrc renamed to dev-packages/e2e-tests/test-applications/aws-lambda-layer-cjs/.npmrc

@@ -0,0 +1,21 @@
+const Sentry = require('@sentry/aws-serverless');
+
+const http = require('http');
+
+async function handle() {
+  await Sentry.startSpan({ name: 'aws-lambda-layer-test-txn', op: 'test' }, async () => {
+    await new Promise(resolve => {
+      http.get('http://example.com', res => {
+        res.on('data', d => {
+          process.stdout.write(d);
+        });
+
+        res.on('end', () => {
+          resolve();
+        });
+      });
+    });
+  });
+}
+
+module.exports = { handle };

dev-packages/e2e-tests/test-applications/aws-lambda-layer/package.json renamed to dev-packages/e2e-tests/test-applications/aws-lambda-layer-cjs/package.json

@@ -4,8 +4,8 @@ child_process.execSync('node ./src/run-lambda.js', {
   stdio: 'inherit',
   env: {
     ...process.env,
-    LAMBDA_TASK_ROOT: '.',
-    _HANDLER: 'handle',
+    LAMBDA_TASK_ROOT: '/var/task',
+    _HANDLER: 'src/lambda-function.handle',
 
     NODE_OPTIONS: '--require @sentry/aws-serverless/dist/awslambda-auto',
     SENTRY_DSN: 'http://public@localhost:3031/1337',

dev-packages/e2e-tests/test-applications/aws-lambda-layer/playwright.config.ts renamed to dev-packages/e2e-tests/test-applications/aws-lambda-layer-cjs/playwright.config.ts

@@ -2,6 +2,6 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';
 
 startEventProxyServer({
   port: 3031,
-  proxyServerName: 'aws-serverless-lambda-layer',
+  proxyServerName: 'aws-serverless-lambda-layer-cjs',
   forwardToSentry: false,
 });

dev-packages/e2e-tests/test-applications/aws-lambda-layer-cjs/src/lambda-function.js

@@ -3,10 +3,14 @@ import { expect, test } from '@playwright/test';
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
 test('Lambda layer SDK bundle sends events', async ({ request }) => {
-  const transactionEventPromise = waitForTransaction('aws-serverless-lambda-layer', transactionEvent => {
+  const transactionEventPromise = waitForTransaction('aws-serverless-lambda-layer-cjs', transactionEvent => {
     return transactionEvent?.transaction === 'aws-lambda-layer-test-txn';
   });
 
+  // Waiting for 1s here because attaching the listener for events in `waitForTransaction` is not synchronous
+  // Since in this test, we don't start a browser via playwright, we don't have the usual delays (page.goto, etc)
+  // which are usually enough for us to never have noticed this race condition before.
+  // This is a workaround but probably sufficient as long as we only experience it in this test.
   await new Promise<void>(resolve =>
     setTimeout(() => {
       resolve();