Skip to content

Commit f7d70a0

Browse files
measurements no longer an invalid type
1 parent 0639e97 commit f7d70a0

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

packages/core/test/lib/tracing/span.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ describe('span', () => {
105105
it('disallows invalid attribute types', () => {
106106
const span = new Span();
107107

108-
/** @ts-expect-error this is invalid */
109-
span.setAttribute('str', {});
110-
111108
/** @ts-expect-error this is invalid */
112109
span.setAttribute('str', null);
113110

packages/types/src/span.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export type SpanAttributes = Partial<{
3030
'sentry.op': string;
3131
'sentry.source': string;
3232
'sentry.sample_rate': number;
33+
measurements: Measurements;
3334
}> &
3435
Record<string, SpanAttributeValue | undefined>;
3536

0 commit comments

Comments
 (0)