Skip to content

Commit f8a5f11

Browse files
committed
fix e2e tests a bit
1 parent 7f47c13 commit f8a5f11

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

.github/workflows/build.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1069,7 +1069,7 @@ jobs:
10691069
ref: ${{ env.HEAD_COMMIT }}
10701070
- uses: pnpm/action-setup@v4
10711071
with:
1072-
version: 8.3.1
1072+
version: 9.4.0
10731073
- name: Set up Node
10741074
uses: actions/setup-node@v4
10751075
with:
@@ -1106,12 +1106,12 @@ jobs:
11061106
- name: Build E2E app
11071107
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
11081108
timeout-minutes: 5
1109-
run: yarn ${{ matrix.build-command || 'test:build' }}
1109+
run: pnpm ${{ matrix.build-command || 'test:build' }}
11101110

11111111
- name: Run E2E test
11121112
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
11131113
timeout-minutes: 5
1114-
run: yarn test:assert
1114+
run: pnpm test:assert
11151115

11161116
- name: Deploy Astro to Cloudflare
11171117
uses: cloudflare/pages-action@v1
@@ -1154,14 +1154,18 @@ jobs:
11541154
]
11551155
build-command:
11561156
- false
1157+
assert-command:
1158+
- false
11571159
label:
11581160
- false
11591161
include:
11601162
- test-application: 'create-remix-app'
11611163
build-command: 'test:build-sourcemaps'
1164+
assert-command: 'test:assert-sourcemaps'
11621165
label: 'create-remix-app (sourcemaps)'
11631166
- test-application: 'create-remix-app-legacy'
11641167
build-command: 'test:build-sourcemaps'
1168+
assert-command: 'test:assert-sourcemaps'
11651169
label: 'create-remix-app-legacy (sourcemaps)'
11661170

11671171
steps:
@@ -1171,7 +1175,7 @@ jobs:
11711175
ref: ${{ env.HEAD_COMMIT }}
11721176
- uses: pnpm/action-setup@v4
11731177
with:
1174-
version: 8.3.1
1178+
version: 9.4.0
11751179
- name: Set up Node
11761180
uses: actions/setup-node@v4
11771181
with:
@@ -1205,12 +1209,12 @@ jobs:
12051209
- name: Build E2E app
12061210
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
12071211
timeout-minutes: 5
1208-
run: yarn ${{ matrix.build-command || 'test:build' }}
1212+
run: pnpm ${{ matrix.build-command || 'test:build' }}
12091213

12101214
- name: Run E2E test
12111215
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
12121216
timeout-minutes: 5
1213-
run: yarn test:assert
1217+
run: pnpm ${{ matrix.assert-command || 'test:assert' }}
12141218

12151219
job_profiling_e2e_tests:
12161220
name: E2E ${{ matrix.label || matrix.test-application }} Test

dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
"clean": "npx rimraf node_modules pnpm-lock.yaml",
1111
"test:build": "pnpm install && npx playwright install && pnpm build",
1212
"test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
13-
"test:assert": "pnpm playwright test"
13+
"test:assert": "pnpm playwright test",
14+
"test:assert-sourcemaps": "pnpm -v"
1415
},
1516
"dependencies": {
1617
"@sentry/remix": "latest || *",

dev-packages/e2e-tests/test-applications/create-remix-app/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
"clean": "npx rimraf node_modules pnpm-lock.yaml",
1111
"test:build": "pnpm install && npx playwright install && pnpm build",
1212
"test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
13-
"test:assert": "pnpm playwright test"
13+
"test:assert": "pnpm playwright test",
14+
"test:assert-sourcemaps": "pnpm -v"
1415
},
1516
"dependencies": {
1617
"@sentry/remix": "latest || *",

0 commit comments

Comments
 (0)