convert isDebugBuild checks from if blocks to short-circuits

Author: lobsterkatie

packages/browser/src/helpers.ts

@@ -192,16 +192,12 @@ export function injectReportDialog(options: ReportDialogOptions = {}): void {
   }
 
   if (!options.eventId) {
-    if (isDebugBuild()) {
-      logger.error('Missing eventId option in showReportDialog call');
-    }
+    isDebugBuild() && logger.error('Missing eventId option in showReportDialog call');
     return;
   }
 
   if (!options.dsn) {
-    if (isDebugBuild()) {
-      logger.error('Missing dsn option in showReportDialog call');
-    }
+    isDebugBuild() && logger.error('Missing dsn option in showReportDialog call');
     return;
   }
 

packages/browser/src/integrations/globalhandlers.ts

@@ -237,9 +237,7 @@ function _enhanceEventWithInitialFrame(event: Event, url: any, line: any, column
 }
 
 function globalHandlerLog(type: string): void {
-  if (isDebugBuild()) {
-    logger.log(`Global Handler attached: ${type}`);
-  }
+  isDebugBuild() && logger.log(`Global Handler attached: ${type}`);
 }
 
 function addMechanismAndCapture(hub: Hub, error: EventHint['originalException'], event: Event, type: string): void {

packages/browser/src/sdk.ts

@@ -162,9 +162,7 @@ export function flush(timeout?: number): PromiseLike<boolean> {
   if (client) {
     return client.flush(timeout);
   }
-  if (isDebugBuild()) {
-    logger.warn('Cannot flush events. No client defined.');
-  }
+  isDebugBuild() && logger.warn('Cannot flush events. No client defined.');
   return resolvedSyncPromise(false);
 }
 
@@ -181,9 +179,7 @@ export function close(timeout?: number): PromiseLike<boolean> {
   if (client) {
     return client.close(timeout);
   }
-  if (isDebugBuild()) {
-    logger.warn('Cannot flush events and disable SDK. No client defined.');
-  }
+  isDebugBuild() && logger.warn('Cannot flush events and disable SDK. No client defined.');
   return resolvedSyncPromise(false);
 }
 
@@ -212,9 +208,7 @@ function startSessionTracking(): void {
   const document = window.document;
 
   if (typeof document === 'undefined') {
-    if (isDebugBuild()) {
-      logger.warn('Session tracking in non-browser environment with @sentry/browser is not supported.');
-    }
+    isDebugBuild() && logger.warn('Session tracking in non-browser environment with @sentry/browser is not supported.');
     return;
   }
 

packages/browser/src/transports/utils.ts

@@ -69,9 +69,8 @@ export function getNativeFetchImplementation(): FetchImpl {
       }
       document.head.removeChild(sandbox);
     } catch (e) {
-      if (isDebugBuild()) {
+      isDebugBuild() &&
         logger.warn('Could not create sandbox iframe for pure fetch check, bailing to window.fetch: ', e);
-      }
     }
   }
 

packages/core/src/basebackend.ts

@@ -92,9 +92,7 @@ export abstract class BaseBackend<O extends Options> implements Backend {
    */
   public sendEvent(event: Event): void {
     void this._transport.sendEvent(event).then(null, reason => {
-      if (isDebugBuild()) {
-        logger.error('Error while sending event:', reason);
-      }
+      isDebugBuild() && logger.error('Error while sending event:', reason);
     });
   }
 
@@ -103,16 +101,12 @@ export abstract class BaseBackend<O extends Options> implements Backend {
    */
   public sendSession(session: Session): void {
     if (!this._transport.sendSession) {
-      if (isDebugBuild()) {
-        logger.warn("Dropping session because custom transport doesn't implement sendSession");
-      }
+      isDebugBuild() && logger.warn("Dropping session because custom transport doesn't implement sendSession");
       return;
     }
 
     void this._transport.sendSession(session).then(null, reason => {
-      if (isDebugBuild()) {
-        logger.error('Error while sending session:', reason);
-      }
+      isDebugBuild() && logger.error('Error while sending session:', reason);
     });
   }
 

packages/core/src/baseclient.ts

@@ -173,16 +173,12 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
    */
   public captureSession(session: Session): void {
     if (!this._isEnabled()) {
-      if (isDebugBuild()) {
-        logger.warn('SDK not enabled, will not capture session.');
-      }
+      isDebugBuild() && logger.warn('SDK not enabled, will not capture session.');
       return;
     }
 
     if (!(typeof session.release === 'string')) {
-      if (isDebugBuild()) {
-        logger.warn('Discarded session because of missing or non-string release');
-      }
+      isDebugBuild() && logger.warn('Discarded session because of missing or non-string release');
     } else {
       this._sendSession(session);
       // After sending, we set init false to indicate it's not the first occurrence

packages/core/src/integrations/inboundfilters.ts

@@ -64,37 +64,33 @@ export class InboundFilters implements Integration {
   /** JSDoc */
   private _shouldDropEvent(event: Event, options: Partial<InboundFiltersOptions>): boolean {
     if (this._isSentryError(event, options)) {
-      if (isDebugBuild()) {
+      isDebugBuild() &&
         logger.warn(`Event dropped due to being internal Sentry Error.\nEvent: ${getEventDescription(event)}`);
-      }
       return true;
     }
     if (this._isIgnoredError(event, options)) {
-      if (isDebugBuild()) {
+      isDebugBuild() &&
         logger.warn(
           `Event dropped due to being matched by \`ignoreErrors\` option.\nEvent: ${getEventDescription(event)}`,
         );
-      }
       return true;
     }
     if (this._isDeniedUrl(event, options)) {
-      if (isDebugBuild()) {
+      isDebugBuild() &&
         logger.warn(
           `Event dropped due to being matched by \`denyUrls\` option.\nEvent: ${getEventDescription(
             event,
           )}.\nUrl: ${this._getEventFilterUrl(event)}`,
         );
-      }
       return true;
     }
     if (!this._isAllowedUrl(event, options)) {
-      if (isDebugBuild()) {
+      isDebugBuild() &&
         logger.warn(
           `Event dropped due to not being matched by \`allowUrls\` option.\nEvent: ${getEventDescription(
             event,
           )}.\nUrl: ${this._getEventFilterUrl(event)}`,
         );
-      }
       return true;
     }
     return false;
@@ -187,9 +183,7 @@ export class InboundFilters implements Integration {
         const { type = '', value = '' } = (event.exception.values && event.exception.values[0]) || {};
         return [`${value}`, `${type}: ${value}`];
       } catch (oO) {
-        if (isDebugBuild()) {
-          logger.error(`Cannot extract message for event ${getEventDescription(event)}`);
-        }
+        isDebugBuild() && logger.error(`Cannot extract message for event ${getEventDescription(event)}`);
         return [];
       }
     }
@@ -224,9 +218,7 @@ export class InboundFilters implements Integration {
       }
       return frames ? this._getLastValidUrl(frames) : null;
     } catch (oO) {
-      if (isDebugBuild()) {
-        logger.error(`Cannot extract url for event ${getEventDescription(event)}`);
-      }
+      isDebugBuild() && logger.error(`Cannot extract url for event ${getEventDescription(event)}`);
       return null;
     }
   }

packages/utils/src/instrument.ts

@@ -94,12 +94,11 @@ function triggerHandlers(type: InstrumentHandlerType, data: any): void {
     try {
       handler(data);
     } catch (e) {
-      if (isDebugBuild()) {
+      isDebugBuild() &&
         logger.error(
           `Error while triggering instrumentation handler.\nType: ${type}\nName: ${getFunctionName(handler)}\nError:`,
           e,
         );
-      }
     }
   }
 }

packages/utils/src/supports.ts

@@ -113,9 +113,8 @@ export function supportsNativeFetch(): boolean {
       }
       doc.head.removeChild(sandbox);
     } catch (err) {
-      if (isDebugBuild()) {
+      isDebugBuild() &&
         logger.warn('Could not create sandbox iframe for pure fetch check, bailing to window.fetch: ', err);
-      }
     }
   }