Skip to content

Commit fd26d9f

Browse files
authored
ref: Move node version to runtime context (#2507)
1 parent 124e71e commit fd26d9f

File tree

3 files changed

+27
-4
lines changed

3 files changed

+27
-4
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,6 @@
6262
},
6363
"resolutions": {
6464
"**/agent-base": "5"
65-
}
65+
},
66+
"version": "0.0.0"
6667
}

packages/node/src/handlers.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,12 @@ export function parseRequest(
235235
};
236236

237237
if (options.version) {
238-
event.extra = {
239-
...event.extra,
240-
node: global.process.version,
238+
event.contexts = {
239+
...event.contexts,
240+
runtime: {
241+
name: 'node',
242+
version: global.process.version,
243+
},
241244
};
242245
}
243246

packages/node/test/handlers.test.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,25 @@ describe('parseRequest', () => {
1818
},
1919
};
2020

21+
describe('parseRequest.contexts runtime', () => {
22+
test('runtime name must contain node', () => {
23+
const parsedRequest: Event = parseRequest({}, mockReq);
24+
expect(parsedRequest.contexts.runtime.name).toEqual('node');
25+
});
26+
27+
test('runtime version must contain current node version', () => {
28+
const parsedRequest: Event = parseRequest({}, mockReq);
29+
expect(parsedRequest.contexts.runtime.version).toEqual(process.version);
30+
});
31+
32+
test('runtime disbaled by options', () => {
33+
const parsedRequest: Event = parseRequest({}, mockReq, {
34+
version: false,
35+
});
36+
expect(parsedRequest).not.toHaveProperty('contexts.runtime');
37+
});
38+
});
39+
2140
describe('parseRequest.user properties', () => {
2241
const DEFAULT_USER_KEYS = ['id', 'username', 'email'];
2342
const CUSTOM_USER_KEYS = ['custom_property'];

0 commit comments

Comments
 (0)