move logic for picking which ember versions to test to ember-try config

Author: lobsterkatie

.github/workflows/build.yml

@@ -231,17 +231,9 @@ jobs:
         with:
           path: ${{ env.CACHED_BUILD_PATHS }}
           key: ${{ env.BUILD_CACHE_KEY }}
-      - name: Check changed files
-        id: changed-files-specific
-        uses: tj-actions/[email protected]
-        with:
-          files: .*packages\/ember($|/.*)
-      # Only run ember tests if the files above have changed
       - name: Run Ember tests
-        if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push'
         run: yarn test --scope=@sentry/ember
       - name: Compute test coverage
-        if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push'
         uses: codecov/codecov-action@v1
 
   job_artifacts:

packages/ember/config/ember-try.js

@@ -3,26 +3,47 @@
 const getChannelURL = require('ember-source-channel-url');
 const { embroiderSafe } = require('@embroider/test-setup');
 
+/**
+ * Pick which versions of ember against which to test based on whether the tests are running locally, as part of a PR,
+ * or when merging to `master` or creating a release.
+ *
+ * @returns The versions which should be tested, along with their respective config
+ */
 module.exports = async function() {
-  return {
-    useYarn: true,
-    scenarios: [
-      {
-        name: 'ember-lts-3.20',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.20.0',
-          },
+  // whenever and wherever we test, we want to at least test against the latest version of ember
+  let scenarios = [
+    {
+      name: 'ember-release',
+      npm: {
+        devDependencies: {
+          'ember-source': await getChannelURL('release'),
         },
       },
+    },
+  ];
+
+  // in CI we add a few more tests - LTS and embroider (which is an ember compiler)
+  if (process.env.GITHUB_ACTIONS) {
+    scenarios = scenarios.concat([
       {
-        name: 'ember-release',
+        name: 'ember-lts-3.20',
         npm: {
           devDependencies: {
-            'ember-source': await getChannelURL('release'),
+            'ember-source': '~3.24.0',
           },
         },
       },
+      embroiderSafe(),
+    ]);
+  }
+
+  // finally, just to be extra thorough when merging to master and releasing, we add the beta channel and ember
+  // "classic" (a legacy version which was last current in late 2019)
+  if (
+    process.env.GITHUB_EVENT_NAME === 'push' &&
+    (process.env.GITHUB_HEAD_REF === 'master' || process.env.GITHUB_HEAD_REF.startsWith('release'))
+  ) {
+    scenarios = scenarios.concat([
       {
         name: 'ember-beta',
         npm: {
@@ -32,7 +53,6 @@ module.exports = async function() {
         },
         allowedToFail: true,
       },
-      embroiderSafe(),
       {
         name: 'ember-classic',
         env: {
@@ -48,6 +68,11 @@ module.exports = async function() {
           },
         },
       },
-    ],
+    ]);
+  }
+
+  return {
+    useYarn: true,
+    scenarios,
   };
 };

packages/ember/package.json

@@ -26,9 +26,7 @@
     "prepublishOnly": "ember ts:precompile",
     "postpublish": "ember ts:clean",
     "start": "ember serve",
-    "test": "node ./scripts/run_tests.js",
-    "test:ember": "ember test",
-    "test:ember-compatibility": "ember try:each"
+    "test": "ember try:each",
   },
   "dependencies": {
     "@embroider/macros": "~0.47.2",