feat(types): Add SerializedEvent
interface (pre v8)
#10240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
SerializedEvent
interface which more accurately represents what an event envelope item contains (i.e. the JSON structure of a serializedEvent
object). Specifically, thespans
field now correctly only contains the attributes the POJO span will continue to hold, i.e. without the deprecations and methods declared in theSpan
interface.In v8, we should change the
EventItem
type for the event envelope but doing so now is a breaking change I believe (And arguably, not too important to do now anyway).However, we can already use this type in our browser integration tests to remove a lot of the unnecessary deprecation ignores.
ref #10222 (rest of this has to happen in v8)