Skip to content

feat(core): Read propagation context off scopes in startSpan APIs #10300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 30, 2024
Merged

feat(core): Read propagation context off scopes in startSpan APIs #10300

merged 11 commits into from
Jan 30, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jan 23, 2024

Read the propagation context off isolation scopes and scopes in startSpan APIs to continue traces if available.

@lforst lforst force-pushed the lforst-isolation-scope-propagation branch from 4e4f46e to 36d4cfe Compare January 25, 2024 13:40
@lforst lforst force-pushed the lforst-start-span-read-prop-context branch from 7d429a5 to ba77925 Compare January 25, 2024 15:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.16 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.37 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.26 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.99 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.39 KB (+0.05% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.29 KB (+0.05% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (+0.01% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (+0.01% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.96 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.51 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.4 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.62 KB (+0.43% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.97 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.99 KB (+0.43% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.89 KB (+0.74% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.51 KB (+0.14% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.76 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.63 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.43 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.74 KB (+0.04% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (-0.04% 🔽)

@lforst lforst marked this pull request as ready for review January 29, 2024 09:28
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad January 29, 2024 09:29
Base automatically changed from lforst-isolation-scope-propagation to develop January 29, 2024 14:35
@lforst lforst merged commit 07a2264 into develop Jan 30, 2024
@lforst lforst deleted the lforst-start-span-read-prop-context branch January 30, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@mydea mydea Awaiting requested review from mydea

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @AbhiPrasad