Skip to content

fix(nextjs): Fix Http integration type declaration #10338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 25, 2024

For some reason const { Http: OriginalHttp } = Integrations caused weirdness around getting type imports from the local build structure instead of importing the type top-level. This PR removes the object destructuring in favour of directly referencing Integrations.Http.

ref #10310 (comment)

(This is part of a couple of fixes we need to get out to fix currently broken type declarations)

Copy link
Contributor

github-actions bot commented Jan 25, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.84 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.93 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.68 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.06 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.25 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.26 KB (0%)
@sentry/browser - Webpack (gzipped) 22.5 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.57 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.13 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.97 KB (-0.08% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.43 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.42 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.44 KB (-0.17% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.08 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.07 KB (-0.09% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.45 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.55 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.11 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.4 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@Lms24 Lms24 requested review from mydea and lforst January 25, 2024 10:20
@Lms24 Lms24 merged commit 96190d7 into develop Jan 25, 2024
@Lms24 Lms24 deleted the lms/fix-http-dts branch January 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants