Skip to content

ref(browser-integration-tests): Fix flake in interaction transaction tests #10365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 26, 2024

This PR decreases the lower bound of the interaction span duration. In the script file, we hard block for 70ms but I've seen test fails where we're just ever so slightly below 70ms (69.x). Figured this is because of some timing inaccuracies.

closes #10363

@Lms24 Lms24 self-assigned this Jan 26, 2024
@Lms24 Lms24 requested review from k-fish and AbhiPrasad January 26, 2024 10:11
@AbhiPrasad
Copy link
Member

Going to merge this in to help CI on develop

@AbhiPrasad AbhiPrasad merged commit 3cc7057 into develop Jan 26, 2024
@AbhiPrasad AbhiPrasad deleted the lms/fix-flake-pw-interaction-test branch January 26, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: Interaction Transaction Firefox
3 participants