Skip to content

build(ci): Use v3 of artifact actions for node-profiling #10522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2024
Merged

build(ci): Use v3 of artifact actions for node-profiling #10522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c835e44
build(ci): Use v3 of artifact actions for node-profiling
mydea Feb 6, 2024
e2be09d
fix profiling tarballs
mydea Feb 6, 2024
2c64186
fix fix node profiling tarball
mydea Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ env:
${{ github.workspace }}/packages/utils/esm

BUILD_CACHE_KEY: ${{ github.event.inputs.commit || github.sha }}
BUILD_CACHE_TARBALL_KEY: tarball-${{ github.event.inputs.commit || github.sha }}
BUILD_PROFILING_NODE_CACHE_TARBALL_KEY: profiling-node-tarball-${{ github.event.inputs.commit || github.sha }}

# GH will use the first restore-key it finds that matches
# So it will start by looking for one from the same branch, else take the newest one it can find elsewhere
Expand Down Expand Up @@ -403,15 +403,15 @@ jobs:
uses: ./.github/actions/restore-cache
env:
DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Profiling
- name: Pack tarballs
# Profiling tarball is built separately as we assemble the precompiled binaries
run: yarn build:tarball --ignore @sentry/profiling-node

- name: Restore profiling tarball
uses: actions/download-artifact@v4
uses: actions/cache/restore@v4
with:
name: profiling-node-tarball-${{ github.sha }}
path: packages/profiling-node
key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
path: ${{ github.workspace }}/packages/*/*.tgz

- name: Archive artifacts
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -1001,7 +1001,7 @@ jobs:
if: |
(needs.job_get_metadata.outputs.changed_profiling_node_bindings == 'true') ||
(github.event_name != 'pull_request')
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
with:
name: profiling-node-binaries-${{ github.sha }}
path: ${{ github.workspace }}/packages/profiling-node/lib/
Expand All @@ -1014,7 +1014,7 @@ jobs:
uses: actions/cache/save@v4
with:
path: ${{ github.workspace }}/packages/*/*.tgz
key: ${{ env.BUILD_CACHE_TARBALL_KEY }}
key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}

job_e2e_tests:
name: E2E ${{ matrix.label || matrix.test-application }} Test
Expand Down Expand Up @@ -1121,7 +1121,7 @@ jobs:
if: |
(needs.job_get_metadata.outputs.changed_profiling_node_bindings == 'true') ||
(github.event_name != 'pull_request')
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
with:
name: profiling-node-binaries-${{ github.sha }}
path: ${{ github.workspace }}/packages/profiling-node/lib/
Expand All @@ -1139,7 +1139,7 @@ jobs:
uses: actions/cache/restore@v4
with:
path: ${{ github.workspace }}/packages/*/*.tgz
key: ${{ env.BUILD_CACHE_TARBALL_KEY }}
key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}

- name: Get node version
id: versions
Expand Down Expand Up @@ -1481,7 +1481,7 @@ jobs:
- name: Archive Binary
# @TODO: v4 breaks convenient merging of same name artifacts
# https://github.com/actions/upload-artifact/issues/478
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: profiling-node-binaries-${{ github.sha }}
path: |
Expand Down