Skip to content

ref(core): Make remaining client methods required #10605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2024
Merged

ref(core): Make remaining client methods required #10605

merged 3 commits into from
Feb 12, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 12, 2024 •
edited
Loading

This makes the following required on the client:

  • captureSession
  • getSdkMetadata
  • addEventProcessor
  • getEventProcessor
  • getIntegrationByName
  • addIntegration
  • init
  • captureAggregrateMetrics

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad February 12, 2024 10:51
@mydea mydea self-assigned this Feb 12, 2024
Lms24
Lms24 approved these changes Feb 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.82 KB (-0.35% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (-0.36% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.97 KB (-0.36% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.67 KB (-0.43% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.21 KB (-0.17% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.08 KB (-0.18% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.11 KB (-0.15% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.1 KB (-0.16% 🔽)
@sentry/browser - Webpack (gzipped) 22.36 KB (-0.19% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.81 KB (-0.34% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.35 KB (-0.37% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.31 KB (-0.18% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.41 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.15 KB (-0.5% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.77 KB (-0.27% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.18 KB (-0.33% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.49 KB (-0.14% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.42 KB (-0.38% 🔽)
@sentry/react - Webpack (gzipped) 22.42 KB (-0.17% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.16 KB (-0.31% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.29 KB (-0.13% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (-0.1% 🔽)

@mydea mydea force-pushed the fn/client-optional-methods branch from afa46ec to 3fa7f0a Compare February 12, 2024 11:00
mydea and others added 3 commits February 12, 2024 13:24
@mydea
ref(core): make remaining client methods required
c2e7bf2 
This makes the following required:

* `captureSession`
* `getSdkMetadata`
* `addEventProcessor`
* `getEventProcessor`
* `getIntegrationByName`
* `addIntegration`
* `init`
* `captureAggregratMetrics`
@mydea @Lms24
Apply suggestions from code review
2c27143 
Co-authored-by: Lukas Stracke <[email protected]>
@mydea
fix
d79216a
@mydea mydea force-pushed the fn/client-optional-methods branch from 3fa7f0a to d79216a Compare February 12, 2024 12:31
@mydea mydea merged commit cb88a7c into develop Feb 12, 2024
@mydea mydea deleted the fn/client-optional-methods branch February 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24