Skip to content

ref: Remove deprecated showReportDialog APIs #10609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Feb 12, 2024

Removes all deprecated showReportDialog APIs. I noticed we had one deprecation too many in there on the exported options type. I will silently remove this deprecation.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.9 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.13 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.05 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.74 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.31 KB (+0.18% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.16 KB (+0.19% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.17 KB (+0.1% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (+0.1% 🔺)
@sentry/browser - Webpack (gzipped) 22.44 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.86 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.42 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.37 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.47 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.59 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.14 KB (+0.2% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.55 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.59 KB (+0.21% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.49 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.47 KB (+0.12% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.31 KB (+0.11% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.42 KB (+0.2% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (0%)

@lforst lforst marked this pull request as ready for review February 12, 2024 12:51
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad February 12, 2024 12:51
@lforst lforst merged commit 3ef44a4 into develop Feb 12, 2024
@lforst lforst deleted the lforst-rm-deprecated-show-report-dialog branch February 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants