feat(core): Lookup client on current scope, not hub #10635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more step to avoid the hub...
Note: This showed a potential footgun (?), where if you pass a client-less scope to
startSpan()
, no span will be created (because no client = no tracing, and the given scope will be made the current scope in the callback). this is correct behavior here, but could be a bit unexpected ("why is no span being created here??"). We could think about warning if a client-less scope is passed in there, but not sure if that's worth it...