Skip to content

feat(v8/browser): Remove XHR transport #10703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Feb 16, 2024

resolves #5927

Removes makeXHRTransport and makes the fetch transport the default one.

I've also added a warning warning to browser client init that states that the sentry browser sdk requires the fetch API to function.

@AbhiPrasad AbhiPrasad requested a review from a team February 16, 2024 21:48
@AbhiPrasad AbhiPrasad self-assigned this Feb 16, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and Lms24 and removed request for a team February 16, 2024 21:48
Copy link
Contributor

github-actions bot commented Feb 16, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.78 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (-0.18% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.97 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.52 KB (-0.33% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.24 KB (-0.32% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.15 KB (-0.3% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.14 KB (-0.18% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.14 KB (-0.18% 🔽)
@sentry/browser - Webpack (gzipped) 22.4 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.03 KB (-0.3% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.53 KB (-0.33% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.49 KB (-0.56% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.68 KB (-0.43% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.29 KB (-0.42% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101 KB (-0.78% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.81 KB (-0.65% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.79 KB (-0.49% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (-0.19% 🔽)
@sentry/react - Webpack (gzipped) 22.43 KB (-0.17% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.82 KB (-0.18% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.06 KB (-0.22% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-xhr-transport branch from 38add7e to 6bc7673 Compare February 20, 2024 14:20
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 20, 2024 14:20
@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-xhr-transport branch from b481a6b to b14d603 Compare February 21, 2024 00:31
@AbhiPrasad AbhiPrasad merged commit b0752b5 into develop Feb 21, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-remove-xhr-transport branch February 21, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref(browser): Remove XHR transport from default bundle
2 participants