Skip to content

feat(v8): Remove deprecated Replay, Feedback, ReplayCanvas exports #10814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 6, 2024
Merged

feat(v8): Remove deprecated Replay, Feedback, ReplayCanvas exports #10814

merged 10 commits into from
Mar 6, 2024

Conversation

AbhiPrasad
Copy link
Member

On the road to deleting Sentry.Integrations exports - we remove all exports for Sentry.Replay, Sentry.Feedback, and Sentry.ReplayCanvas.

ref #8844

@AbhiPrasad AbhiPrasad self-assigned this Feb 26, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Feb 26, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.38 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.58 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.5 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.14 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.84 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.84 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.34 KB (+0.02% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.35 KB (0%)
@sentry/browser - Webpack (gzipped) 22.56 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.43 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.05 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.91 KB (-0.23% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.97 KB (-0.39% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.54 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.34 KB (-0.15% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.65 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.05 KB (-0.19% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.87 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.59 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.3 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.7 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.41 KB (+0.04% 🔺)

c298lee
c298lee reviewed Feb 26, 2024
View reviewed changes
c298lee
c298lee reviewed Feb 26, 2024
View reviewed changes
@AbhiPrasad AbhiPrasad force-pushed the abhi-replay-integration-changs branch 2 times, most recently from 989139d to cc945f2 Compare March 4, 2024 23:16
@AbhiPrasad
Copy link
Member Author

This is now ready for another review!

@AbhiPrasad AbhiPrasad force-pushed the abhi-replay-integration-changs branch from 40ecfdf to a2eb16e Compare March 5, 2024 22:11
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 5, 2024 22:32
@AbhiPrasad AbhiPrasad merged commit cd9b896 into develop Mar 6, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-replay-integration-changs branch March 6, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c298lee c298lee c298lee left review comments

@billyvg billyvg billyvg approved these changes

@mydea mydea mydea approved these changes

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbhiPrasad @billyvg @mydea @c298lee