Skip to content

build(remix): Skip Node 18 & 16 integration tests because they often segfault #11107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

build(remix): Skip Node 18 & 16 integration tests because they often segfault #11107

merged 1 commit into from
Mar 14, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 14, 2024

@mydea mydea self-assigned this Mar 14, 2024
onurtemizkan
onurtemizkan approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@onurtemizkan onurtemizkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to get to the root of this.

@AbhiPrasad
Copy link
Member

merging this in because I can't even merge changelog without it :(

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 14, 2024 17:09
@AbhiPrasad AbhiPrasad merged commit b9b4cb2 into develop Mar 14, 2024
@AbhiPrasad AbhiPrasad deleted the fn/skip-remix-integration-tests branch March 14, 2024 17:17
@onurtemizkan onurtemizkan mentioned this pull request Mar 17, 2024
Merged
Lms24 pushed a commit that referenced this pull request Mar 18, 2024
@onurtemizkan
chore(tests): Remove --detectOpenHandles from Jest config. (#11148)
30db115 
Ref: #11107

Removes `--detectOpenHandles` from Jest configurations of Remix and
Next.JS which apparently causes segfault.

Re-enables Remix Node 16 and Node 18 integration tests on CI
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@onurtemizkan @cadesalaberry
chore(tests): Remove --detectOpenHandles from Jest config. (getsent…
6348572 
…ry#11148)

Ref: getsentry#11107

Removes `--detectOpenHandles` from Jest configurations of Remix and
Next.JS which apparently causes segfault.

Re-enables Remix Node 16 and Node 18 integration tests on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurtemizkan onurtemizkan onurtemizkan approved these changes

@lforst lforst lforst approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mydea @AbhiPrasad @onurtemizkan @lforst