-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(feedback): Add getFeedback
utility to get typed feedback instance
#11331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { getCurrentScope } from '@sentry/core'; | ||
import { getFeedback } from './getFeedback'; | ||
import { feedbackIntegration } from './integration'; | ||
import { mockSdk } from './mockSdk'; | ||
|
||
describe('getFeedback', () => { | ||
beforeEach(() => { | ||
getCurrentScope().setClient(undefined); | ||
}); | ||
|
||
it('works without a client', () => { | ||
const actual = getFeedback(); | ||
expect(actual).toBeUndefined(); | ||
}); | ||
|
||
it('works with a client without Feedback', () => { | ||
mockSdk({ | ||
sentryOptions: { | ||
integrations: [], | ||
}, | ||
}); | ||
|
||
const actual = getFeedback(); | ||
expect(actual).toBeUndefined(); | ||
}); | ||
|
||
it('works with a client with Feedback', () => { | ||
const feedback = feedbackIntegration(); | ||
|
||
mockSdk({ | ||
sentryOptions: { | ||
integrations: [feedback], | ||
}, | ||
}); | ||
|
||
const actual = getFeedback(); | ||
expect(actual).toBeDefined(); | ||
expect(actual === feedback).toBe(true); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { getClient } from '@sentry/core'; | ||
import type { feedbackIntegration } from './integration'; | ||
|
||
/** | ||
* This is a small utility to get a type-safe instance of the Feedback integration. | ||
*/ | ||
export function getFeedback(): ReturnType<typeof feedbackIntegration> | undefined { | ||
const client = getClient(); | ||
return client && client.getIntegrationByName<ReturnType<typeof feedbackIntegration>>('Feedback'); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice not to need this anymore!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for reference, the reason we generally have this is because for most integrations, we do not want to expose to users what shape they have, as then we cannot refactor internals anymore - we only expose it if we have to (which we do for replay & feedback) :)